992327 - Change directoryLinks and NewTabUtils to imageURI instead of imageURISpec

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Ed Lee :Mardak]

from adw: hey, i saw the json in one of the bugs, and i feel bad about asking you to call the image uri property imageURISpec.  please feel free to change it back to imageURI if it's not too much trouble, preemptive r+!

Comment 1

[Olivier Yiptong [:oyiptong]]

Attachment: v1

Comment 2

[Ed Lee :Mardak]

https://hg.mozilla.org/integration/fx-team/rev/07b0a0f32570

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/07b0a0f32570

Comment 4

[Marco Mucci [:MarcoM]]

Hi Anthony, can you review if this resolved bug will need further verification.  Thanks.

Comment 5

[u279076]

Ed, does this area of code have tests already? If so manual spotchecking is probably not worth it. If not, we should probably at least check that image rendering hasn't regressed from this change. What are some things we can be checking if that's the case.

Comment 6

[Ed Lee :Mardak]

adw, I don't think there's tests that check for the value of background-image style to see if it's set to url(moz-page-thumb://..) vs url(imageURI). Do you think it'll be good to create that test?

Comment 7

[u279076]

(In reply to Ed Lee :Mardak from comment #6)
> adw, I don't think there's tests that check for the value of
> background-image style to see if it's set to url(moz-page-thumb://..) vs
> url(imageURI). Do you think it'll be good to create that test?

Probably not of much use to have this test. What's important is ensuring images continue to render when they should. If this isn't done automatically somewhere currently then we should explore adding that test. However in the meantime we can check manually. What functionality is affected by this code change?

Comment 8

[u279076]

Sorry for forgetting to needinfo you. Ed, can you please answer comment 7?

Comment 9

[Ed Lee :Mardak]

There isn't really any functionality change. It's just renaming a variable/key that we had in a reference data file and updating uses of that key.

Comment 10

[u279076]

Tagging [qa-] based on comment 9.