992347 - add mozilla::ipc::FatalError and mozilla::dom::PBrowserChild::FatalError on the skip list

Status: RESOLVED FIXED

(Socorro :: Backend, task)

Description

[Brad Lassey [:blassey] (use needinfo?)]

I wonder if it should be *::FatalError? Bill? Blake?

Comment 1

[Laura Thomson :laura]

Needed for e10s, pretty urgent.

Comment 2

[K Lars Lohn [:lars] [:klohn]]

which skip list?  prefix or ignore?

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to K Lars Lohn [:lars] [:klohn] from comment #2)
> which skip list?  prefix or ignore?

I think ignore. What's the prefix skip list?

Comment 4

[K Lars Lohn [:lars] [:klohn]]

prefix list items get added to the beginning of a signature separated with "|".  For example: if the ignore list contains XXXX and prefix contains YYYY,  and the stack looks like:

XXXX
YYYY
XXXX
ZZZZ
AAAA

then then signature will be "YYYY | ZZZZ"

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Ahh. In that case prefix sounds like the right option.

Comment 6

[K Lars Lohn [:lars] [:klohn]]

final word on use of wildcards or literal match?

Comment 7

[K Lars Lohn [:lars] [:klohn]]

Attachment: PR for prefix skip list addition

I've taken the liberty of changing it to a regular expression of the form:

    mozilla.*FatalError

That should catch both cases as well as similar ones.

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to K Lars Lohn [:lars] [:klohn] from comment #7)
> Created attachment 8402015 [details] [review]
> PR for prefix skip list addition
> 
> I've taken the liberty of changing it to a regular expression of the form:
> 
>     mozilla.*FatalError
> 
> That should catch both cases as well as similar ones.

perfect, thanks

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/014385e347833a58855bcafb02f9fc802d99642a
Merge pull request #1979 from twobraids/fatalerror

Fixes Bug 992347 : adds 'mozilla.*FatalError' to prefix list