Closed Bug 992359 Opened 8 years ago Closed 8 years ago

Add off-Gecko-thread support to NativeJSObject

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 32

People

(Reporter: jchen, Assigned: jchen)

Details

Attachments

(5 files, 1 obsolete file)

No description provided.
Comment on attachment 8416042 [details] [diff] [review]
a. Make AutoIdArray::operator!() const

operator! should be const.
Attachment #8416042 - Attachment description: Bug 992359 - Make AutoIdArray::operator!() const; → a. Make AutoIdArray::operator!() const
Attachment #8416042 - Flags: review?(till)
Comment on attachment 8416043 [details] [diff] [review]
b. Add skeletal NativeJSObject.toBundle (v1)

This patch adds Bundle methods to NativeJSObject so that we can produce a Bundle from a NativeJSObject. The Bundle can be saved for later and/or can be used off the Gecko thread.
Attachment #8416043 - Attachment description: Bug 992359 - Add skeletal NativeJSObject.toBundle; → b. Add skeletal NativeJSObject.toBundle (v1)
Attachment #8416043 - Flags: review?(blassey.bugs)
Actual implementation of GetBundle
Attachment #8416049 - Flags: review?(blassey.bugs)
Adds some null check and clean up.
Attachment #8416053 - Flags: review?(blassey.bugs)
Test for Bundle support. Depends on the test in bug 1003670.
Comment on attachment 8416042 [details] [diff] [review]
a. Make AutoIdArray::operator!() const

Review of attachment 8416042 [details] [diff] [review]:
-----------------------------------------------------------------

I agree
Attachment #8416042 - Flags: review?(till) → review+
Attachment #8416043 - Flags: review?(blassey.bugs) → review+
Attachment #8416049 - Flags: review?(blassey.bugs) → review+
Attachment #8416053 - Flags: review?(blassey.bugs) → review+
Add tests for toBundle and getBundle
Attachment #8416077 - Attachment is obsolete: true
Attachment #8419506 - Flags: review?(blassey.bugs)
Attachment #8419506 - Flags: review?(blassey.bugs) → review+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.