992359 - Add off-Gecko-thread support to NativeJSObject

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: a. Make AutoIdArray::operator!() const

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: b. Add skeletal NativeJSObject.toBundle (v1)

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8416042 [details] [diff] [review]
a. Make AutoIdArray::operator!() const

operator! should be const.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8416043 [details] [diff] [review]
b. Add skeletal NativeJSObject.toBundle (v1)

This patch adds Bundle methods to NativeJSObject so that we can produce a Bundle from a NativeJSObject. The Bundle can be saved for later and/or can be used off the Gecko thread.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: c. Add GetBundle implementation (v1)

Actual implementation of GetBundle

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: d. Properly handle nullptr context (v1)

Adds some null check and clean up.

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: e. Add Bundle test to testEventDispatcher (v1)

Test for Bundle support. Depends on the test in bug 1003670.

Comment 8

[Till Schneidereit [:till]]

Comment on attachment 8416042 [details] [diff] [review]
a. Make AutoIdArray::operator!() const

Review of attachment 8416042 [details] [diff] [review]:
-----------------------------------------------------------------

I agree

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: e. Add Bundle test to testEventDispatcher (v2)

Add tests for toBundle and getBundle

Comment 10

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c85aa5e660aa
https://hg.mozilla.org/integration/mozilla-inbound/rev/780dcee9c352
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4105f1b09fc
https://hg.mozilla.org/integration/mozilla-inbound/rev/db16539ca29c
https://hg.mozilla.org/integration/mozilla-inbound/rev/0af06fdea04a

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c85aa5e660aa
https://hg.mozilla.org/mozilla-central/rev/780dcee9c352
https://hg.mozilla.org/mozilla-central/rev/e4105f1b09fc
https://hg.mozilla.org/mozilla-central/rev/db16539ca29c
https://hg.mozilla.org/mozilla-central/rev/0af06fdea04a