Closed
Bug 992383
Opened 11 years ago
Closed 11 years ago
Notification removal triggers error
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.4 S5 (11apr)
People
(Reporter: gerard-majax, Assigned: mikehenrty)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
With Gecko/Gaia from a couple of minutes ago, opening a SMS thread, logcat shows the following:
E/GeckoConsole( 1695): [JavaScript Error: "TypeError: this.lockScreenContainer is null" {file: "app://system.gaiamobile.org/js/notifications.js" line: 471}]
|
Assignee | |
Comment 1•11 years ago
|
||
Caused by bug 937442. Looks like we will need to make sure the lockScreenContainer is not null when removing notifications, like we did for when adding notifications [1].
1.) https://github.com/mozilla-b2g/gaia/commit/9f21d2c750b4c642f77bd3bf638f0f2fea93fb08#diff-6
|
|
Assignee | |
Comment 2•11 years ago
|
||
Greg, can you take a look at this?
Attachment #8402546 -
Flags: review?(gweng)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8402546 [details] [review]
Github PR
OK. The patch seems reasonable, so I give the review+.
It may still need Travis result to be landed.
Attachment #8402546 -
Flags: review?(gweng) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Travis went green, merged to master: https://github.com/mozilla-b2g/gaia/commit/26d6c4162938e55c90433f73081d7901f11e1852
Thanks for the quick review Greg!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•