992393 - [camera][madai] preview mode UI updates

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Tiffanie Shakespeare [:tif]]

Based on feedback from usability testing as well as comments from within the team (e.g. Diego), we have made some updates to the preview UI.

I am working on a spec page now which will be posted here as soon as I'm done.

There are 2 strings additions:
1. Preview
2. Open Gallery

Possibly need string Delete? Is this already in the file?

Comment 1

[Tiffanie Shakespeare [:tif]]

flagging Axel for string items.

Comment 2

[Rob MacDonald [:robmac]]

Just some additional background on the rationale for this. During the recent user study we identified a few issues surrounding the navigation between Camera preview and Gallery. Users were getting stuck and having difficulties returning to the viewfinder.

The proposed changes (to be posted shortly) are intended to eliminate these navigation issues and ensure users don't miss their shot.

Comment 3

[Axel Hecht [:Pike]]

Thanks for the heads-up. I don't see a question for me to answer, though, sorry.

Comment 4

[Tiffanie Shakespeare [:tif]]

Attachment: UI spec

Find proposal attached!

Comment 5

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8402082 [details]
UI spec

Making sure David has a chance to take a look at the proposal in case Hema hasn't spoken with him yet.

Comment 6

[Wilson Page [:wilsonpage]]

Thanks peeps, looks much better :)

Who would be best to implement this? Should Hyuna take it, seeing as Preview-Gallery is sort of her domain?

Comment 7

[David Flanagan [:djf]]

Tif,

Here are my thoughts/questions on the new design:

1) I'd think that deleting photos is more common than sharing, and I would have expected the delete action to be the easiest one to get to. But maybe that is because I'm comparing to dedicated digital cameras that don't have a share option.

2) With this header bar at the top, can we force the entire preview into portrait mode?  Or do you expect everything to work in landscape as well?  If we force the user to rotate their phone when previewing then we don't have the issue with the share menu.  But we don't give as good a preview experience for landscape photos, of course.

3) Does the "Open Gallery" button just switch to the gallery thumbnail page as currently, or is it supposed to open the current image in the gallery? That is, is it "Open gallery" or "Open in gallery"? The latter would require feature changes to Gallery that are out of scope for 1.4, so if you're okay with just opening the gallery app as we do now, that's great.

Comment 8

[David Flanagan [:djf]]

(In reply to Wilson Page [:wilsonpage] from comment #6)
> Thanks peeps, looks much better :)
> 
> Who would be best to implement this? Should Hyuna take it, seeing as
> Preview-Gallery is sort of her domain?

I'm working on a couple of bugs to try to improve the swiping and panning behavior, and there is a lot of overlap with this bug.  So if someone starts working on this, keep me in the loop. If I start making quick progress on those other bugs, I'll consider taking this one myself.

Comment 9

[Tiffanie Shakespeare [:tif]]

Hi David - thanks for the comments.

In this design we can only have one action visible while other are pushed to a secondary menu. When comparing the three actions we (Rob & I) think that the most likely action in preview is going to be sharing. We also think that given the destructive nature of delete, it's ok to make it a little more difficult.

In the new design, we don't intend to lock the orientation - it should work in both portrait and landscape. I've made a note to add the information to the spec to make that more clear.

The "open gallery" action will also work in the same manner as it currently does, so there are no changes to that flow other than the method of launching (from the action menu). Again, I'll add that to the spec.

Thanks!

(In reply to David Flanagan [:djf] from comment #7)
> Tif,
> 
> Here are my thoughts/questions on the new design:
> 
> 1) I'd think that deleting photos is more common than sharing, and I would
> have expected the delete action to be the easiest one to get to. But maybe
> that is because I'm comparing to dedicated digital cameras that don't have a
> share option.
> 
> 2) With this header bar at the top, can we force the entire preview into
> portrait mode?  Or do you expect everything to work in landscape as well? 
> If we force the user to rotate their phone when previewing then we don't
> have the issue with the share menu.  But we don't give as good a preview
> experience for landscape photos, of course.
> 
> 3) Does the "Open Gallery" button just switch to the gallery thumbnail page
> as currently, or is it supposed to open the current image in the gallery?
> That is, is it "Open gallery" or "Open in gallery"? The latter would require
> feature changes to Gallery that are out of scope for 1.4, so if you're okay
> with just opening the gallery app as we do now, that's great.

Comment 10

[Tiffanie Shakespeare [:tif]]

Attachment: UI spec

Comment 11

[Amy Lee [:amylee] UX]

Hi, 

I've mocked up a visual of how this should look. The back icon/header text should be the same as the camera settings menu. The black bar height/colour is the same as the current bar. The two icons on the right follow our positioning rules in the building blocks. 

See link 
Header: http://buildingfirefoxos.com/building-blocks/headers.html

Action Menu: http://buildingfirefoxos.com/building-blocks/action-menu.html

Comment 12

[Amy Lee [:amylee] UX]

Attachment: CSS_Pixels_Image_Preview_Spec.jpg

Image preview spec

Comment 13

[Amy Lee [:amylee] UX]

Also, an FYI. I think the positioning of the image number should be left unchanged since we still have grey bars at the top and bottom of the image and we don't want to lower the image number text too close to the grey bars.

Comment 14

[Amy Lee [:amylee] UX]

Please see comment 13 since in the UX spec it calls for the image number to be lowered.

Comment 15

[Tiffanie Shakespeare [:tif]]

Attachment: preview revamp.pdf

Deferring to Amy for placement of counter within preview. Removed comment in spec.

Comment 16

[Hema Koka [:hema]]

Youngjun, please assign this (4/15 is camera FC - that is bugs need to be fixed and landed on 1.4 by that date)

Thanks
Hema

Comment 17

[Axel Hecht [:Pike]]

Adding late-l10n as this might come with new strings, AFAICT.

Comment 18

[hyuna.cho]

I'm in vacation from tomorrow until Sunday.
It's a risky schedule to fix and review by 15th Apr.
I will ask to our other engineer(Ashish or Verchaswa) to implement it, if anyone can't take it.

And please upload the new icons.

Comment 19

[Tiffanie Shakespeare [:tif]]

NI Amy for icon request.

Comment 20

[psingapati]

assigning to Verchaswa as per his request.

Comment 21

[Amy Lee [:amylee] UX]

Attachment: ImagePreview-Options.svg

Hi

Attached is the "options" icon for image preview. The rest you should already have.

Comment 22

[ver4ffos]

Attachment: pull request

Comment 23

[Wilson Page [:wilsonpage]]

Comment on attachment 8404652 [details] [review]
pull request

- You have copied across a lot of files from relating to action_menu. AFAIK this is not how shared components are designed to be used. Have a look at /shared/style/confirm.css and /shared/style/buttons.css are used.
- navigator.mozL10n is referenced at runtime. This fragile as you don't know if the l10n.js library has fully loaded yet.
- Icons in action menu are italicised.

Copying in amlee and tif as this will require their sign off too.

Comment 24

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8404652 [details] [review]
pull request

Hello!

Overall nice job and thanks for getting this together so quickly. Here are my comments:

- The back, menu, share buttons don't need to be in circles since they are in the header bar.
- Counter should disappear/reappear with header bar when user taps on the screen

Bugs:
Tapping the menu, then delete, then cancel/delete should go back to preview not the viewfinder. I also noticed that when this happens the link to preview is replaced with gallery.

Sometimes my tap to hide/show the elements zooms in instead of hiding when doing it multiple times.

Tapping some of the share menu items returns me to the preview instead of doing the action (e.g. email, messages)

Comment 25

[Amy Lee [:amylee] UX]

Comment on attachment 8404652 [details] [review]
pull request

Hi, 

The circles can be removed from the icons since they are sitting in a toolbar. The icons/header text/arrow are too big. 

The styling and sizes should follow the building blocks style guide here: 

https://bugzilla.mozilla.org/show_bug.cgi?id=992393

Font size and icon size/placement: Look at Default -> Example -> "Messages" Header 
Size and location of back to camera arrow: Look at Skins -> Example -> "Song Title" Header

For the dialogue menu please remove the trash can and grid icons.

Fade-out menu transition:
Please stretch out the fade-out transition so it matches the menu fade out in the Video App.

Thanks!

Comment 26

[Wilson Page [:wilsonpage]]

Comment on attachment 8404652 [details] [review]
pull request

- There is still styling in preview-gallery that is handling manual rotation. Since djf's patch landed to allow device rotation inside the preview-gallery, this is no longer required.
- No unit-tests. I'd like to see some unit-tests added to PreviewGalleryView and PreviewGalleryController proving the spec has been implemented.

Comment 27

[ver4ffos]

Attachment: previewMode.patch

Work in progress for test cases.

Comment 28

[ver4ffos]

Requesting your feedback on this WIP.

Comment 29

[Hema Koka [:hema]]

Adding DJF or Justin for feedback -- don't know if wilson got a chance to check this before he left for the day

Comment 30

[David Flanagan [:djf]]

Hema: there is nothing to give feedback on here: Verchaswa marked his patch as obsolete. The patch was a CSS change, not the unit tests that Wilson requested.

Verchaswa: you shouldn't need to remove those lines of CSS manually, I don't think. If you rebase your patch on top of master, they should just be removed by that process, I hope. I meant to comment here when I landed my patch to mention that there were possible conflicts. What I have done is modified preview mode so that the system monitors device orientation and rotates the screen as needed. So we no longer have to do any CSS rotation in the preview gallery.

Comment 31

[Amy Lee [:amylee] UX]

Comment on attachment 8404652 [details] [review]
pull request

Adding Tiff for UX review.

Comment 32

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8404652 [details] [review]
pull request

There are still some issues with the layout/look for the header building block. I spoke with Amy and she is preparing a spec that will go into more details with that item.

From the interaction side of things, I see a few issues:
- tapping more icon, then delete - you quickly see the image again before the delete dialogue.
- also with deleting an image, no matter if you tap delete or cancel, you do now return to preview, but the header has disappeared. It should still be visible since the user did not dismiss it. (share does not seem to have this issue)

Comment 33

[Tiffanie Shakespeare [:tif]]

Also note (the first wireframe in the attached PDF) that the gallery icon should be removed. There should either be the link to preview or nothing.

Comment 34

[Amy Lee [:amylee] UX]

Comment on attachment 8404652 [details] [review]
pull request

Hi, 

There are still issues with the positioning of the items. I am attaching a spec for reference. 

In addition to the spec. Please remove the icons in the more options dialogue (Open Gallery/Delete) and make the text italic.

Thanks

Comment 35

[Amy Lee [:amylee] UX]

Attachment: Preview_Toolbar_Spec.png

Attached is a spec for the edits. Thanks!

1. Header Bar height - Please make this 50px (All items should be vertically centre aligned to this bar)

2. Back arrow - Please move this 8px to the left

3. Header Text - Please move this 12px to the left

4. Options Icon - Icon size should be 19px wide. Please move icon 20px to the right

5. Share Icon - Icon size should be 20px wide. Please move icon 40px to the right

Comment 36

[ver4ffos]

 -- For taping issue : There are two pop ups one after another, so before opening second we have to close first one. So because of it shows the image.
 -- Second issue is fixed.

(In reply to Tiffanie Shakespeare from comment #32)
> Comment on attachment 8404652 [details] [review]
> pull request
> 
> There are still some issues with the layout/look for the header building
> block. I spoke with Amy and she is preparing a spec that will go into more
> details with that item.
> 
> From the interaction side of things, I see a few issues:
> - tapping more icon, then delete - you quickly see the image again before
> the delete dialogue.
> - also with deleting an image, no matter if you tap delete or cancel, you do
> now return to preview, but the header has disappeared. It should still be
> visible since the user did not dismiss it. (share does not seem to have this
> issue)

Comment 37

[Tiffanie Shakespeare [:tif]]

Justin/David - can you think of any way to do some magic and prevent (or hide) this issue?

- tapping more icon, then delete - you quickly see the image again before
> the delete dialogue.

Comment 38

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8404652 [details] [review]
pull request

see my comment #33 - I'm still seeing the gallery link before the first photo is taken.

Also - is it me or do the share/menu icons seem smaller than previously? I"ll let Amy comment more on this.

Comment 39

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8404652 [details] [review]
pull request

oops forgot the -. See comment above.

Comment 40

[ver4ffos]

- I have removed gallery button from camera preview.
- I have set share/menu icon font size as per Amy comments in comment #35.

(In reply to Tiffanie Shakespeare from comment #38)
> Comment on attachment 8404652 [details] [review]
> pull request
> 
> see my comment #33 - I'm still seeing the gallery link before the first
> photo is taken.
> 
> Also - is it me or do the share/menu icons seem smaller than previously?
> I"ll let Amy comment more on this.

Comment 41

[Wilson Page [:wilsonpage]]

amlee: If changes need to be made to the header bar, should they be made to the shared building block directly, or should we be writing CSS to override the default styles? The latter seems risky. For maintainability we should probably try to to touch building block styling as little as possible.

Comment 42

[Amy Lee [:amylee] UX]

Comment on attachment 8404652 [details] [review]
pull request

Hi

1. Header text should be vertically centered to the bar (please move 3px up)

2. Icons are too small (Please make them 52% larger). I had specified the width of the icon and not the size of the font in my spec so I think there was some confusion there.

3. Back arrow highlight state over laps with the text. Please match the style of the highlight state in the building blocks under - “Skins”  http://buildingfirefoxos.com/building-blocks/headers.html#

4. What is the "Share Receiver" option in the share menu? It says it's a test app so I assume it will be removed when it lands on master?
  
Thanks!

Comment 43

[Amy Lee [:amylee] UX]

(In reply to Wilson Page [:wilsonpage] from comment #41)
> amlee: If changes need to be made to the header bar, should they be made to
> the shared building block directly, or should we be writing CSS to override
> the default styles? The latter seems risky. For maintainability we should
> probably try to to touch building block styling as little as possible.

Hi Wilson, 

The header in the camera is a unique case in that it's semi-transparent and I don't think we have that style of header anywhere else in the OS. Also, there is going to be a overhaul of the building blocks for 2.1.

Comment 44

[David Flanagan [:djf]]

(In reply to Tiffanie Shakespeare from comment #37)
> Justin/David - can you think of any way to do some magic and prevent (or
> hide) this issue?
> 
> - tapping more icon, then delete - you quickly see the image again before
> > the delete dialogue.

I don't know how we display the menu for the delete/gallery choice, but if that is some kind of shared code, then we probably can't control when that menu is hidden, and that means that that menu will hide before we can process the user's choice and display the delete dialog. That would mean that we'd have to explicitly hide the preview before displaying the menu so that it was not visible when the menu was removed.

Comment 45

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8404652 [details] [review]
pull request

From the interaction side of things - it looks good.

I agree with Amy's comments and I'll let you follow up with her to get the visual pieces correct.

Comment 46

[Hema Koka [:hema]]

Youngjun - please put an ETA today when this will land in 1.4 branch? 
And please make sure to add tests...

We are already way too late for 1.4 localization work on camera...

Comment 47

[David Flanagan [:djf]]

Comment on attachment 8404652 [details] [review]
pull request

Taking this review from Wilson and giving r- because:

- the unit tests fail on Travis

- the view class has a strange mix of creating some elements with DOM calls and some elements with innerHTML. I can't see any reason for not creating the entire options dialog with innerHTML.

- Localization can be done with data-l10n-id attributes on the elements. You shouldn't have to call get() explicitly.  Possibly you may need to call navigator.mozL10N.translate() on the container, but I'm not sure that that is necessary.  (See apps/sms/js/action_menu.js for an example if you want)

- there are a number of naming issues that make your code hard to understand.  Simple changes to method and property names will make it more understandable.

- I think the preview header ought to use styles from shared/css/header.css. If you did that, and if you put the share and options buttons in a <menu type="toolbar"> element (see http://buildingfirefoxos.com/building-blocks/headers.html) I suspect that would fix the icon size issue you are having.

- Your patch changes file permissions from 644 to 755, setting executable bits on the files. Please figure out a way to leave the permissions unchanged in your pull request.

- There are a lot of unnecessary changes in icons.css, which makes it hard to review. Is that file automatically updated when the icon font is changed? If so, then ignore this comment. But if not, please try to minimize the changes in your patch so it is easier to review.

Comment 48

[David Flanagan [:djf]]

I had hoped to be able to fix the issues identified in comment #42 and get this landed tonight, but after reviewing the patch I've run out of time to work on it myself.

Comment 49

[ver4ffos]

- Unit test error fixed.
- apps/camera/style/icons.css got changed automatically updated as we added options icon.
- File permissions corrected.
- Amy's comments incorporated.
- Naming convention corrected.


(In reply to David Flanagan [:djf] from comment #48)
> I had hoped to be able to fix the issues identified in comment #42 and get
> this landed tonight, but after reviewing the patch I've run out of time to
> work on it myself.

Comment 50

[ver4ffos]

Please note because of my timezone difference, turn around time will be delayed.

Comment 51

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8404652 [details] [review]
pull request

The options in the more action menu aren't doing anything. 

Tapping open gallery returns to the viewfinder instead of launching the gallery.

Tapping delete also returns to the viewfinder without presenting a confirmation, though the photo doesn't appear to be getting deleted.

In both cases, after returning to the viewfinder, the link to the preview is gone.

The share action menu didn't seem to have any issues.

Comment 52

[Hema Koka [:hema]]

((In reply to ver4ffos from comment #50)
> Please note because of my timezone difference, turn around time will be
> delayed.

ETA please, taking into account timezone differences since you have already been working on it (David has taken up some other high priority blockers for today). This one has localization impact as well and therefore would like to address it as soon as possible. 

Wilson and David will help review the code changes

THanks
Hema

Comment 53

[Amy Lee [:amylee] UX]

Comment on attachment 8404652 [details] [review]
pull request

Hi, 

Some of the positioning/sizing that you had correct is now incorrect in the new patch.

1. The back arrow size and position was correct in the last patch. Now it’s too big and the position is too far to the right (please revert it back to the original size/position you had it)

2. The opacity of the bar is now too light (please revert back to the original opacity you had)

3. The back arrow position is now incorrect (please revert back to the original position you had)

4. Please vertically centre align the share and options icons (they are too high up)

5. Please move the “options” icon 1px to the left

6. Please move the header text 2px to the left

7. All the highlight state sizes is now correct but the colour should be blue #008eab. Also, please make this 30% transparancy for all hit states.

Comment 54

[Amy Lee [:amylee] UX]

Attachment: Preview_Image.png

Updated Preview Feedback

Comment 55

[Wilson Page [:wilsonpage]]

Comment on attachment 8404652 [details] [review]
pull request

- Delete fails to delete images. Quits preview-gallery and has no confirmation dialog.

I have fixed in my own branch here: https://github.com/wilsonpage/gaia/compare/992393?expand=1

All else looks fine code-wise.

Visually the header-bar doesn't look great as it's always cut in half by the top of the picture. Perhaps we should consider a solid background color?

Comment 56

[Amy Lee [:amylee] UX]

Comment on attachment 8404652 [details] [review]
pull request

Flagging Tiff for UI review

Comment 57

[Amy Lee [:amylee] UX]

(In reply to Amy Lee [:amylee] from comment #53)
> Comment on attachment 8404652 [details] [review]
> pull request
> 
> Hi, 
> 
> Some of the positioning/sizing that you had correct is now incorrect in the
> new patch.
> 
> 1. The back arrow size and position was correct in the last patch. Now it’s
> too big and the position is too far to the right (please revert it back to
> the original size/position you had it)
> 
> 2. The opacity of the bar is now too light (please revert back to the
> original opacity you had)
> 
> 3. The back arrow position is now incorrect (please revert back to the
> original position you had)
> 
> 4. Please vertically centre align the share and options icons (they are too
> high up)
> 
> 5. Please move the “options” icon 1px to the left
> 
> 6. Please move the header text 2px to the left
> 
> 7. All the highlight state sizes is now correct but the colour should be
> blue #008eab. Also, please make this 30% transparancy for all hit states.

I just noticed that there is a drop shadow on the back arrow that needs to be removed. Thanks!

Comment 58

[Amy Lee [:amylee] UX]

(In reply to Wilson Page [:wilsonpage] from comment #55)
> Comment on attachment 8404652 [details] [review]
> pull request
> 
> - Delete fails to delete images. Quits preview-gallery and has no
> confirmation dialog.
> 
> I have fixed in my own branch here:
> https://github.com/wilsonpage/gaia/compare/992393?expand=1
> 
> All else looks fine code-wise.
> 
> Visually the header-bar doesn't look great as it's always cut in half by the
> top of the picture. Perhaps we should consider a solid background color?

Hi Wilson, 

The transparency of the toolbar on the latest patch is wrong (it should be darker). I think with the fix it wouldn't look as bad. I want to keep it semi transparent to be consistent with the gallery app and depending on the device, the size of the grey bars varies or is non-existent if the image is full screen.

Comment 59

[Amy Lee [:amylee] UX]

Comment on attachment 8404652 [details] [review]
pull request

It looks like the delete issue has been fixed but I'll let Tiff give the official UX approval.

Comment 60

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8404652 [details] [review]
pull request

Thanks Wilson for fixing the delete issue. Looks good!

Comment 61

[Amy Lee [:amylee] UX]

Comment on attachment 8404652 [details] [review]
pull request

The visuals still need to be fixed.

Comment 62

[Amy Lee [:amylee] UX]

Comment on attachment 8404652 [details] [review]
pull request

Hi, 

Here's my feedback:

1. Options Icon: Please make the “options” icon 10% bigger and move 3px lower (So it’s vertically centred aligned to the bar)

2. Share Icon: Please make the “share” icon 5% bigger and move 1px lower (So it’s vertically centred aligned to the bar)

3. Back Arrow: Please make the back arrow 10% smaller

4. Highlight State: Please have the icons sit on top of the highlight state and not below it.

Thanks. Almost there!

Comment 63

[Hema Koka [:hema]]

Thanks so much Justin for picking this up. Looks like the strings for these are same (delete, cancel) as the dialog bug 991396 that UX really wants us to get it in for 1.4. Lets shoot to get both wrapped up today. 

Wilson/David, please help with reviews.

Hema

Comment 64

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8404652 [details] [review]
pull request

It looks good from the interaction side of things - nice job!

Comment 65

[Justin D'Arcangelo [:justindarc]]

Attachment: pull-request (master)

Taking this over to try and get it landed today. Made UI tweaks requested by Amy in Comment 62.

David: I don't think this patch has gone through code review yet. If you can review it, I can make any necessary fixes.

Amy: Please review this new PR from my branch.

Thanks!

Comment 66

[Amy Lee [:amylee] UX]

Attachment: Icons.zip

Icons for image preview

Comment 67

[Amy Lee [:amylee] UX]

Comment on attachment 8407708 [details] [review]
pull-request (master)

Looks great! Thanks.

Comment 68

[David Flanagan [:djf]]

This looks good and is ready to land.

It is 1.4+ and should be uplifted. Note, however, that it will not work correctly on the 1.4 branch without also uplifting bug 991396.  This one is the 1.4 blocker, but that one has two localization strings that this one needs, so they have to be uplifted together.

Comment 69

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/7591e9dc782ac2e97d63a96f9deb71c7b3588328

Needs uplifted to 1.4. As David mentioned, the patch for Bug 991396 also needs uplifted to 1.4 before this one.

Bug 991396 on master:

https://github.com/mozilla-b2g/gaia/commit/e151331f5688d933fad4b9da067ffdd57653b733

Comment 70

[Hema Koka [:hema]]

(In reply to Justin D'Arcangelo [:justindarc] from comment #69)
> Landed on master:
> 
> https://github.com/mozilla-b2g/gaia/commit/
> 7591e9dc782ac2e97d63a96f9deb71c7b3588328
> 
> Needs uplifted to 1.4. As David mentioned, the patch for Bug 991396 also
> needs uplifted to 1.4 before this one.
> 
> Bug 991396 on master:
> 
> https://github.com/mozilla-b2g/gaia/commit/
> e151331f5688d933fad4b9da067ffdd57653b733

Thanks Justin and David for taking care of this bug today!

Comment 71

[Ryan VanderMeulen [:RyanVM]]

This needs rebasing on v1.4, even with bug 991396 uplifted.

Comment 72

[Justin D'Arcangelo [:justindarc]]

Attachment: pull-request (v1.4)

Uplift PR for v1.4. Carrying R+ forward.

Comment 73

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/1becbfefddc9411fc55475e5b1750396ba93730c

Thanks :)

Comment 74

[Seth Miko [:SMiko]]

No STR is present to create test case to address bug.

Comment 75

[KTucker [:KTucker][Inactive 3/4/2016]]

Test case added in moztrap:

https://moztrap.mozilla.org/manage/case/14341/