Closed
Bug 992413
Opened 11 years ago
Closed 11 years ago
Add back StubURLVersionAppend to stub ping
Categories
(Firefox :: Installer, defect)
Tracking
()
RESOLVED
FIXED
Firefox 31
| Tracking | Status | |
|---|---|---|
| firefox28 | --- | unaffected |
| firefox29 | --- | unaffected |
| firefox30 | + | fixed |
| firefox31 | --- | fixed |
| firefox-esr24 | --- | unaffected |
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
(Keywords: regression, Whiteboard: [stubv2+][qa-])
Attachments
(1 file)
|
1.69 KB,
patch
|
TimAbraldes
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Accidentally removed when in bug 899363.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8402074 -
Flags: review?(tabraldes)
|
|
Assignee | |
Updated•11 years ago
|
Blocks: 899363
Keywords: regression
|
|
Assignee | |
Updated•11 years ago
|
status-firefox28:
--- → unaffected
status-firefox29:
--- → unaffected
status-firefox30:
--- → affected
status-firefox31:
--- → affected
status-firefox-esr24:
--- → unaffected
tracking-firefox30:
--- → ?
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8402074 [details] [diff] [review]
simple patch
Review of attachment 8402074 [details] [diff] [review]:
-----------------------------------------------------------------
Verified that this patch does indeed add back ${StubURLVersionAppend}. I'm assuming that the other changes introduced by bug 899363 are desired and work properly.
Attachment #8402074 -
Flags: review?(tabraldes) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/1d0434bb0a62
Flags: in-testsuite-
|
|
Assignee | |
Updated•11 years ago
|
Summary: Add back ${StubURLVersionAppend} to stub ping → Add back StubURLVersionAppend to stub ping
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 8402074 [details] [diff] [review]
simple patch
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 899363
User impact if declined: None. This is used to send the funnelcake id for funnelcake experiments.
Testing completed (on m-c, etc.): On m-c and tested locally
Risk to taking this patch (and alternatives if risky): extremely minimal
String or IDL/UUID changes made by this patch: none
Attachment #8402074 -
Flags: approval-mozilla-aurora?
|
||
Updated•11 years ago
|
|
|
||
Updated•11 years ago
|
Attachment #8402074 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
||
Comment 6•11 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•