Closed Bug 992472 Opened 9 years ago Closed 7 years ago

Investigate uses of ARRAY_PUSH and ARRAY_SLICE in self-hosted code for spec-conformity

Categories

(Core :: JavaScript: Standard Library, defect)

Product:
Core
Component:
JavaScript: Standard Library
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla46
Tracking Flags:
Tracking Status
firefox46 --- fixed

People

(Reporter: till, Assigned: till)

Details

Attachments

(1 file)

Remove self-hosting macros ARRAY_PUSH and ARRAY_SLICE
1.28 KB, patch
efaust
: review+
Details | Diff | Splinter Review 
As Waldo points out, the ARRAY_PUSH and ARRAY_SLICE macros defined in SelfHostingDefines.h might well be misused as they invoke getters/setters.
Assignee: general → nobody
ARRAY_PUSH and ARRAY_SLICE are no longer used, we should just remove both #defines in SelfHostingDefines.h
Because anba said so.
Attachment #8708403 - Flags: review?(efaustbmo)
Assignee: nobody → till
Status: NEW → ASSIGNED
Comment on attachment 8708403 [details] [diff] [review]
Remove self-hosting macros ARRAY_PUSH and ARRAY_SLICE

Review of attachment 8708403 [details] [diff] [review]:
-----------------------------------------------------------------

Well, if anba said so....
Attachment #8708403 - Flags: review?(efaustbmo) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb237e4cf9a22195ee505114136515dbab1626e1
Bug 992472 - Remove self-hosting macros ARRAY_PUSH and ARRAY_SLICE. r=efaust
https://hg.mozilla.org/mozilla-central/rev/fb237e4cf9a2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.