992569 - Toolkit's password prompts should have product name in the window title

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[bege10]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20140314220517

Steps to reproduce:

For entering the general password in Firefox there is a window with the title "Passwort erforderlich" (in German, English translation: Password necessary).
This window title is exactly the same as in Thunderbird.
To make auto-type of password managers more usable, please, add "Firefox" to the window title.

Comment 2

[YF (Yang)]

I do not think this is a good idea.

Your password managers rely only the window title, it can't judge the process name or something else?

Comment 3

[YF (Yang)]

Sorry, I would like to withdraw previously said, maybe it can bring some help.

Comment 4

[florent.de-dinechin]

I support this bug report. We have a window poping up from anywhere, we don't know if it is from the OS (which has background tasks checking for updates etc) or from firefox, so we don't know which password to enter. The window should mention explicitely the Firefox master password.
(french interface for me).

Also, how difficult is it to set up a nasty web page that opens a popup that is identical to the firefox one, to capture user passwords?
I'd rather type my master password in the main window of Firefox. But that would be a different bug I guess.

Comment 5

[bege10]

Please, this is definitely little effort to accomplish and big help for users.
Thank you very much.

Comment 6

[Nikhil Gupta]

Hi,
I want to work on this. What exactly should I change the content into?

Comment 7

[YF (Yang)]

(In reply to Nikhil Gupta from comment #6)
> Hi,
> I want to work on this. What exactly should I change the content into?

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide

https://dxr.mozilla.org/mozilla-central/search?q=PromptPassword2
Add a like the https://dxr.mozilla.org/mozilla-central/search?q=GetStringFromName%28%22brandShortName%22%29%3B


Hmmm, actually I have a patch for it once, but I'm not sure it is better for product, so I didn't submit it.

Comment 8

[YF (Yang)]

Attachment: bug992569 v1.diff

For reference, it may require some changes to adapt to the current base.

Comment 9

[Albert Scheiner [:alberts]]

The platform is set to Windows, but I am pretty sure it's the same on Mac. Should this be set to all?

Comment 10

[hardik tyagi [:hrdktg]]

Hello, Is this bug currently being worked on by someone? 
If not can i work on this?

Comment 11

[Othmar]

Hi there,
so I've decided to try my luck with this one as my first bug, and I've already got a working build :)

Here is the code I use:
```
const BRANDING_BUNDLE_URI = "chrome://branding/locale/brand.properties";
var brandShortName = Services.strings.
                       createBundle(BRANDING_BUNDLE_URI).
                       GetStringFromName("brandShortName");
```

If anyone can help me how to continue I would be grateful, else I will try to dig through the documentation to find out the next step myself. Also any kind of feedback is appreciated.

Comment 12

[Zertrin]

How can this move forward? There is already a patch provided and this seems like a simple fix. What is blocking?

Comment 14

[Kai Engert (:KaiE:)]

Comment on attachment 8716911 [details] [diff] [review]
bug992569 v1.diff

>-PromptUsernameAndPassword2=Authentication Required
>-PromptPassword2=Password Required
>+# LOCALIZATION NOTE - %S is brandShortName
>+PromptUsernameAndPassword2=%S Authentication Required
>+# LOCALIZATION NOTE - %S is brandShortName
>+PromptPassword3=%S Password Required

You forgot to change 2 to 3 in PromptUsernameAndPassword2

Comment 15

[Kai Engert (:KaiE:)]

Comment on attachment 8716911 [details] [diff] [review]
bug992569 v1.diff

Surrounding code has changed. Marking obsolete.

Other windows seems to show the title as
  information - product name

I'll submit a phabricator patch.

Comment 16

[Kai Engert (:KaiE:)]

Attachment: Bug 992569 - Toolkit's password prompts should have product name in the window title. r?MattN

Based on a contribution from YF (Yang).

Comment 17

[Kai Engert (:KaiE:)]

kmag, mconley: For users who have a master password set, they will get a small, separate prompt for the master password. This enhancement is suggested to make it more obvious into which application they'll enter it.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5dd2196d74f9
Toolkit's password prompts should have product name in the window title. r=MattN

Comment 20

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on browser_autocomplete_master_password.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/8809e56d7fd3b80ca312fd4fcc9ac0028f022ee2
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287713387&repo=autoland&lineNumber=19725

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f039e58254b
Toolkit's password prompts should have product name in the window title. r=MattN

Comment 22

[Kai Engert (:KaiE:)]

The test failures were caused by tests that look for an exact match of the Window title. Which no longer was working, because we changed the window title. The updated commit fixes the tests.

Comment 23

[Matthew N. [:MattN]]

The merge to m-c will resolve the bug with appropriate flags. We don’t resolve on autoland.

Comment 24

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0f039e58254b

Comment 25

[bege10]

Thank you very much for fixing :-)