Closed Bug 992569 Opened 7 years ago Closed 2 years ago
Toolkit's password prompts should have product name in the window title
47 bytes, text/x-phabricator-request
|Details | Review|
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release) Build ID: 20140314220517 Steps to reproduce: For entering the general password in Firefox there is a window with the title "Passwort erforderlich" (in German, English translation: Password necessary). This window title is exactly the same as in Thunderbird. To make auto-type of password managers more usable, please, add "Firefox" to the window title.
Severity: normal → minor
Component: Untriaged → General
Product: Firefox → Toolkit
Sorry, I would like to withdraw previously said, maybe it can bring some help.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Windows title for general password entry → Add product name to the "Password Required" window title
I support this bug report. We have a window poping up from anywhere, we don't know if it is from the OS (which has background tasks checking for updates etc) or from firefox, so we don't know which password to enter. The window should mention explicitely the Firefox master password. (french interface for me). Also, how difficult is it to set up a nasty web page that opens a popup that is identical to the firefox one, to capture user passwords? I'd rather type my master password in the main window of Firefox. But that would be a different bug I guess.
Please, this is definitely little effort to accomplish and big help for users. Thank you very much.
Hi, I want to work on this. What exactly should I change the content into?
(In reply to Nikhil Gupta from comment #6) > Hi, > I want to work on this. What exactly should I change the content into? https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide https://dxr.mozilla.org/mozilla-central/search?q=PromptPassword2 Add a like the https://dxr.mozilla.org/mozilla-central/search?q=GetStringFromName%28%22brandShortName%22%29%3B Hmmm, actually I have a patch for it once, but I'm not sure it is better for product, so I didn't submit it.
For reference, it may require some changes to adapt to the current base.
The platform is set to Windows, but I am pretty sure it's the same on Mac. Should this be set to all?
Whiteboard: [good first bug] → [good first bug] [passwords:master-password]
Hello, Is this bug currently being worked on by someone? If not can i work on this?
Hi there, so I've decided to try my luck with this one as my first bug, and I've already got a working build :) Here is the code I use: ``` const BRANDING_BUNDLE_URI = "chrome://branding/locale/brand.properties"; var brandShortName = Services.strings. createBundle(BRANDING_BUNDLE_URI). GetStringFromName("brandShortName"); ``` If anyone can help me how to continue I would be grateful, else I will try to dig through the documentation to find out the next step myself. Also any kind of feedback is appreciated.
Summary: Add product name to the "Password Required" window title → Toolkit's password prompts should have product name in the window title
Comment on attachment 8716911 [details] [diff] [review] bug992569 v1.diff >-PromptUsernameAndPassword2=Authentication Required >-PromptPassword2=Password Required >+# LOCALIZATION NOTE - %S is brandShortName >+PromptUsernameAndPassword2=%S Authentication Required >+# LOCALIZATION NOTE - %S is brandShortName >+PromptPassword3=%S Password Required You forgot to change 2 to 3 in PromptUsernameAndPassword2
Attachment #8716911 - Flags: review-
Comment on attachment 8716911 [details] [diff] [review] bug992569 v1.diff Surrounding code has changed. Marking obsolete. Other windows seems to show the title as information - product name I'll submit a phabricator patch.
Attachment #8716911 - Attachment is obsolete: true
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/5dd2196d74f9 Toolkit's password prompts should have product name in the window title. r=MattN
Attachment #9123161 - Attachment description: Bug 992569 - Toolkit's password prompts should have product name in the window title. r?mconley → Bug 992569 - Toolkit's password prompts should have product name in the window title. r?MattN
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/0f039e58254b Toolkit's password prompts should have product name in the window title. r=MattN
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla74 → ---
You need to log in before you can comment on or make changes to this bug.