992613 - The branding files are missing for gtk3 widget toolkit (for aurora and official branding)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[hev [:hev]]

Attachment: Fix-up-branding-files-missing-for-gtk3-widget-toolki.patch

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20140319120302

Steps to reproduce:

Building the latest Firefox with GTK+3 widget toolkit.


Actual results:

The branding files are not linked to obj-xxx-xxx-xxx/dist/braning/.


Expected results:

Create a lot of symbol file links to obj-xxx-xxx-xxx/dist/braning/:
default16.png 
default32.png 
default48.png 
mozicon128.png

Comment 1

[:Gijs (he/him)]

Comment on attachment 8402251 [details] [diff] [review]
Fix-up-branding-files-missing-for-gtk3-widget-toolki.patch

Awesome, thanks for the patch! I'll have to reformat it into hg's format, then I'll reattach it and set checkin-needed so we can get this on Nightly ASAP. :-)

Comment 2

[:Gijs (he/him)]

Attachment: Fix up branding files missing for gtk3 widget toolkit when using aurora or official branding,

Comment 3

[Carsten Book [:Tomcat]]

congrats to your first patch and thanks for contributing to mozilla!

https://hg.mozilla.org/integration/fx-team/rev/03053afabaa0

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/03053afabaa0