992644 - EverythingME.log: Bind to window.console object

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Amir Nissim (:amirn)]

After updating gecko to build > 3/30/2014 the following error shows in the console after |reset-gaia|:

E/GeckoConsole(  612): [JavaScript Error: "TypeError: 'log' called on an object that does not implement interface Console." {file: "app://homescreen.gaiamobile.org/everything.me/js/everything.me.js" line: 589}]

This is a new constraint on console.log bindings introduced in bug 965860 and is already reported in bug 989619.

Comment 1

[Amir Nissim (:amirn)]

Attachment: Pull Request

Comment 2

[Amir Nissim (:amirn)]

landed in master: https://github.com/mozilla-b2g/gaia/commit/7104c8f9a9f90047c118388473ad0403193c859e

Comment 3

[Amir Nissim (:amirn)]

if bug 965860 makes it into v1.4 this one is blocker

Comment 4

[Jason Smith [:jsmith]]

(In reply to Amir Nissim (Everything.me) from comment #3)
> if bug 965860 makes it into v1.4 this one is blocker

What's the user impact of this bug?

Comment 5

[Amir Nissim (:amirn)]

(In reply to Jason Smith [:jsmith] from comment #4)
> (In reply to Amir Nissim (Everything.me) from comment #3)
> > if bug 965860 makes it into v1.4 this one is blocker
> 
> What's the user impact of this bug?

E.me will not load at all :(

Comment 6

[Jason Smith [:jsmith]]

(In reply to Amir Nissim (Everything.me) from comment #5)
> (In reply to Jason Smith [:jsmith] from comment #4)
> > (In reply to Amir Nissim (Everything.me) from comment #3)
> > > if bug 965860 makes it into v1.4 this one is blocker
> > 
> > What's the user impact of this bug?
> 
> E.me will not load at all :(

With what STR? We've never seen this problem from end user testing.

Comment 7

[Amir Nissim (:amirn)]

(In reply to Jason Smith [:jsmith] from comment #6)
> With what STR? We've never seen this problem from end user testing.

See comment 0
https://bugzilla.mozilla.org/show_bug.cgi?id=992644#c0

Comment 8

[Jason Smith [:jsmith]]

(In reply to Amir Nissim (Everything.me) from comment #7)
> (In reply to Jason Smith [:jsmith] from comment #6)
> > With what STR? We've never seen this problem from end user testing.
> 
> See comment 0
> https://bugzilla.mozilla.org/show_bug.cgi?id=992644#c0

That doesn't really provide context of how an end user will hit this bug. We've never seen this in an end-user testing at all.

Comment 9

[Ran Ben Aharon [:ranbena] EverythingMe]

Device: Unagi
Gecko build: 12bd943 (Apr 3rd Telefonica Nightly build)
Gaia build: 1acd82e4 (Apr 6th)

STR:
1. Open a Smart Collection

Result: Won't load apps.

STR:
1. Click on Searchbar
2. Keyboard appears

Result: Screen doesn't transition to search.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/352f0e41dc217c78b7841e3fea4e4733b94f1587