992684 - Keefox makes the bookmark button looks slightly broken on hover (Windows)

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Bret Comnes]

Attachment: button bug.png

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140403132807

Steps to reproduce:

When I mouse over the bookmark button in windows Australis, the button shadow looks messed up.


Actual results:

The button looks like its missing a visual boarder or something when you mouse over it.


Expected results:

The button shouldn't look that way.

Comment 1

[Tim Nguyen :ntim]

I couldn't reproduce on Windows XP or 8, and I don't have a Windows 7 machine.

Can you reproduce on a clean profile ?

Comment 2

[:Gijs (he/him)]

(In reply to Tim Nguyen [:ntim] from comment #1)
> I couldn't reproduce on Windows XP or 8, and I don't have a Windows 7
> machine.
> 
> Can you reproduce on a clean profile ?

I can't reproduce on Windows 7 either. Reporter, could you check on a clean profile? ( https://support.mozilla.org/kb/profile-manager-create-and-remove-firefox-profiles )

Comment 3

[Bret Comnes]

On a fresh profile it looks better.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Thanks, on the profile that is broken, can you go to about:config and copy the value for the browser.uiCustomization.state and add it to this bug? I'm curious if a separator or something else got placed between the bookmarks star and the dropdown.

Comment 5

[Bret Comnes]

Here you go!  I'm sorry :p


{"placements":{"PanelUI-contents":["edit-controls","zoom-controls","new-window-button","privatebrowsing-button","save-page-button","print-button","history-panelmenu","fullscreen-button","find-button","preferences-button","add-ons-button","developer-button","feed-button","abp-toolbarbutton","BetterPrivacyButton","lmnpop-toolbtn","sync-button","email-link-button","greasemonkey-tbb","widget:[e-mail]-subtome","button--subtomesoeren-hentzschelat-subtome"],"KeeFox-Toolbar":["KeeFox_Menu-Button","KeeFox_Main-Button","KeeFox_Logins-Button"],"addon-bar":["addonbar-closebutton","status-bar"],"PersonalToolbar":["personal-bookmarks"],"nav-bar":["urlbar-container","search-container","bookmarks-menu-button","webrtc-status-button","downloads-button","home-button","social-share-button"],"TabsToolbar":["tabbrowser-tabs","new-tab-button","alltabs-button","tabs-closebutton"],"toolbar-menubar":["menubar-items"]},"seen":["button--subtomesoeren-hentzschelat-subtome"],"dirtyAreaCache":["nav-bar","PanelUI-contents","KeeFox-Toolbar","addon-bar","PersonalToolbar","TabsToolbar","toolbar-menubar"],"newElementCount":1}

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Thanks! No need to apologize.

Nothing seems out of the ordinary in your nav-bar. You could see if one of your add-ons is the cause, by disabling half of your add-ons, seeing if you can reproduce the problem, disabling another half, etc.

Comment 7

[Bret Comnes]

Wow, who would have thought Keefox could cause a toolbar bug like this?  Should I report to the author?  Keefox does not work on OS X which would explain why it wasn't showing up there, even though I sync browser profiles.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Thanks for the details! Yes, contacting the author would be the next step.

Comment 9

[Bret Comnes]

I notified the author of the addon:
https://github.com/luckyrat/KeeFox/issues/262

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Bret Comnes from comment #9)
> I notified the author of the addon:
> https://github.com/luckyrat/KeeFox/issues/262

Thanks, I also marked the author for 'needinfo' on this bug, so hopefully between both of our attempts they notice :)

Comment 11

[Chris Tomlinson]

Yep, I've noticed. Thanks for the heads-up, a fix is in the pipeline and should be available in a beta version on AMO within a few days.

Comment 12

[Chris Tomlinson]

I've put the stable version containing the fix into the AMO review queue: https://addons.mozilla.org/en-US/firefox/addon/keefox/versions/1.4.0

What's the best way to close this ticket? Should we wait until AMO have approved it?

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

We can close this now, and then switch it from 'resolved' to 'verified' once the add-on has been published on AMO and somebody has confirmed that it fixes the issue.