992747 - "View">"Toolbars">"My toolbar" toggle not working for non-customizable toolbars

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Arunkumar]

Attachment: google.xpi

The toolbar toggle is not working in Firefox 29.
The menu item is added in firefox menu for my own add on.
"View">"Toolbars">"Own toolbar".  But clicking this item does not toggle my toolbar.
I have attached my sample toolbar.

Comment 1

[:Gijs (he/him)]

As a workaround, make the toolbar customizable...

Comment 2

[:Gijs (he/him)]

Attachment: toolbar visibility setting doesn't work for non-customizable toolbars,

Comment 3

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/67e72ea05f66

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/67e72ea05f66

Comment 5

[:Gijs (he/him)]

Comment on attachment 8403679 [details] [diff] [review]
toolbar visibility setting doesn't work for non-customizable toolbars,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: non-functioning items in toolbar context menus and other places where toolbar visibility can be toggled
Testing completed (on m-c, etc.): on m-c, has automated test
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 6

[:Gijs (he/him)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0708916df1f5
https://hg.mozilla.org/releases/mozilla-beta/rev/04e63b14de25

Comment 7

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

https://hg.mozilla.org/releases/mozilla-beta/diff/04e63b14de25/browser/components/customizableui/test/browser_992747_toggle_noncustomizable_toolbar.js

Comment 8

[Arunkumar]

Hi,
Suppose i hidden my toolbar programmatically  using below code .
 var toolbarObject = win.document.getElementById("my-toolbar-ID");
 if(toolbarObject!=null && ("undefined" != typeof (toolbarObject)))
{
				toolbarObject.setAttribute("collapsed", true);
}

Then toolbar hidden from browser but its not persistent for successive launch of browser. If i re-opened or opened new window then the toolbar is displayed on browser. 
I wanted the toolbar is hidden until that toolbar is displayed  from the option  "View">"Toolbars">"Own toolbar".


But if toolbar toggled from the  option "View">"Toolbars">"Own toolbar" then the behavior stored persistently and toolbar status is  same for successive launch of browser.

Please help me how to programmatically toggle my own toolbar persistently?

Comment 9

[:Gijs (he/him)]

Please don't ever reopen closed bugs to ask for help programming your add-on.

You can get help by posting to mozilla.dev.extensions: https://groups.google.com/forum/#!forum/mozilla.dev.extensions // https://lists.mozilla.org/listinfo/dev-extensions