992851 - Google flight search: book button does not work

Status: RESOLVED FIXED

(Web Compatibility :: Site Reports, defect)

Description

[Hallvord R. M. Steen [:hallvors]]

1) http://www.google.com/flights
2) Search for some flight
3) Pick outgoing and return flights
4) Tap the "book" button

Bug: screen goes darker, nothing more happens

Comment 1

[Hallvord R. M. Steen [:hallvors]]

This appears at the top of the page, rather than inside the viewport:

<div class="gwt-PopupPanel GLMPNSJCADB" style="visibility: visible; overflow: visible; position: absolute; left: 14px; top: 133px;">

In Android stock browser it appears where it's probably intended to, centered vertically in viewport. CSS is presumably different..

Comment 2

[Hallvord R. M. Steen [:hallvors]]

This is probably the code that calculates the style.top value:

	e = (Y$(), em($doc)) - $k(a.ab, u3c) >> 1;
	f = dm($doc) - $k(a.ab, t3c) >> 1;
	C4(a, OWc(Wl($doc.body) + e, 0), OWc((el($doc.body) | 0) + f, 0));

Specifically, the code  f = dm($doc) - $k(a.ab, t3c) >> 1; is basically  document.documentElement.clientHeight - div.offsetHeight /2

OWc((el($doc.body) | 0) + f is basically Math.max(document.body.scrollTop, 0) and here is the bug: the code that reads clientHeight takes document.compatMode into account:

function dm(a){return (bXc(a.compatMode,z2c)?a.documentElement:a.body).clientHeight|0}

But the code that reads scrollHeight doesn't:

function el(a){return a.scrollTop||0}
.
.
el($doc.body)

If compatMode is CSS1Compat, it should read scrollTop of document.documentElement, not document.body. This breaks the "lightbox" effect when scrolled down both in Firefox and Opera.

Comment 3

[Karl Dubost💡 :karlcow]

Alex has been contacted today.

Comment 4

[Karl Dubost💡 :karlcow]

Tested today on Firefox OS without issues.
This seems to have been fixed. We received the tier1 it seems.