992878 - HTTP cache v2: test_bug437844.xul | Assertion count 21 is greater than expected range 20-20 assertions

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Honza Bambas (:mayhemer)]

Regular failure of this low quality test with some recent changes for cache2 [1] on all/all M(oth).

This test is pretty sensitive, last quite recent change that changed the number of assertions was bug 948901 that touched some FTP stuff!

I suggest to set a range 20-21 here.

[1] https://tbpl.mozilla.org/?tree=Gum&rev=e2ddcc1e064a

Comment 1

[Honza Bambas (:mayhemer)]

Attachment: v1

Comment 2

[[e-mail]]

The test is checking that representative pages are rendered in RTL in RTL locales. In my case I changed the DOM of one of the pages to fix an unrelated bug, and this triggered some layout assertions which as far as I can tell are unrelated to either the test or the bug I was fixing. Worse, the assertions depended on what was cached, which made reproducing them tricky, and might well explain why you're seeing extra assertions as you tweak the cache.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8402730 [details] [diff] [review]
v1

Could you make sure a bug is filed on the assertions if there isn't one already, and add a bug number to the comment?

(That would be a normal expectation, except that this dates back to the original set of annotations of existing assertions when we started checking for assertions in mochitest, so it doesn't have that.)

Comment 4

[Honza Bambas (:mayhemer)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/167291c2fd24

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/167291c2fd24