992888 - FileHandle: Some methods should throw when the window is closed

Status: NEW

(Core :: DOM: Core & HTML, defect, P2)

Description

[Jan Varga [:janv]]

+++ This bug was initially created as a clone of Bug #860731 +++

Copying and pasting review comments that were raised in bug 860731. We decided to fix them separately since they don't directly relate to the WebIDL conversion.

Review of attachment 8391945 [details] [diff] [review] [diff] [review]:
-----------------------------------------------------------------

Looks ok, but:

::: dom/file/LockedFile.cpp
@@ +443,5 @@
>    }
>  
> +  // Do nothing if the window is closed
> +  if (!GetOwner()) {
> +    return nullptr;

I think this should throw, right? Below too.

::: dom/file/LockedFile.h
@@ +235,5 @@
> +      return nullptr;
> +    }
> +
> +    if (!length) {
> +      return nullptr;

Shouldn't this return a request?

@@ +240,5 @@
> +    }
> +
> +    // Do nothing if the window is closed
> +    if (!GetOwner()) {
> +      return nullptr;

Shouldn't this set aRv?

Comment 1

[Florian Bender]

What's blocking this work?