Closed
Bug 992890
Opened 12 years ago
Closed 12 years ago
The ability to enter in reader mode is lost
Categories
(Firefox for Android Graveyard :: Reader View, defect)
Tracking
(firefox30 unaffected, firefox31 verified, fennec31+)
VERIFIED
FIXED
Firefox 31
| Tracking | Status | |
|---|---|---|
| firefox30 | --- | unaffected |
| firefox31 | --- | verified |
| fennec | 31+ | --- |
People
(Reporter: CristinaM, Assigned: jchen)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
1.05 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Environment:
Build: Firefox for Android 31.0a1 (2014-04-07)
Device: Asus Transformer (Android 4.2.1)
Steps to reproduce:
1. Go to news.google.com and tap on any news from the list.
2. Tap on Reader mode icon.
Expected result:
The page is switched to the reader mode.
Actual result:
Nothing happens.
|
Reporter | |
Comment 1•12 years ago
|
||
Regression window:
Last good revision: 5fa70bd90a8b
First bad revision: 5405d6f4e3c6
Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5fa70bd90a8b&tochange=5405d6f4e3c6
Logcat:
04-07 16:11:38.561: E/GeckoEventDispatcher(11693): handleGeckoMessage throws org.json.JSONException: No value for type
04-07 16:11:38.561: E/GeckoEventDispatcher(11693): org.json.JSONException: No value for type
04-07 16:11:38.561: E/GeckoEventDispatcher(11693): at org.json.JSONObject.get(JSONObject.java:354)
04-07 16:11:38.561: E/GeckoEventDispatcher(11693): at org.json.JSONObject.getString(JSONObject.java:510)
04-07 16:11:38.561: E/GeckoEventDispatcher(11693): at org.mozilla.gecko.EventDispatcher.dispatchEvent(EventDispatcher.java:179)
04-07 16:11:38.561: E/GeckoEventDispatcher(11693): at org.mozilla.gecko.GeckoAppShell.handleGeckoMessage(GeckoAppShell.java:2292)
04-07 16:11:38.561: E/GeckoEventDispatcher(11693): at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
04-07 16:11:38.561: E/GeckoEventDispatcher(11693): at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
04-07 16:11:38.561: E/GeckoEventDispatcher(11693): at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
04-07 16:11:38.561: E/GeckoEventDispatcher(11693): at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:346)
04-07 16:11:38.561: E/GeckoEventDispatcher(11693): at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:174)
It seems that Bug 989046 caused this regression.
|
Assignee | |
Comment 3•12 years ago
|
||
A couple of reader mode messages still use the old format.
Attachment #8402769 -
Flags: review?(mark.finkle)
|
|
Assignee | |
Updated•12 years ago
|
|
||
Updated•12 years ago
|
tracking-fennec: --- → ?
status-firefox30:
--- → unaffected
|
||
Comment 4•12 years ago
|
||
Comment on attachment 8402769 [details] [diff] [review]
Use new message structure for reader mode events (v1)
thanks
Attachment #8402769 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
|
||
Comment 7•12 years ago
|
||
Verified as fixed in build 31.0a1 (2014-09-04).
Device: Asus Transformer Tab (Android 4.2.1).
|
||
Updated•12 years ago
|
tracking-fennec: ? → 31+
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•