993229 - Display useful error when auth token is no longer valid

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P1)

Description

[Mark Côté [:mcote]]

When the cookie (XMLRPC) or token (REST) expires or is otherwise rendered invalid, we need to alert the user.  This can be detected both from a form submission (publishing changes) or via AJAX call (e.g. reviewer autocomplete).

We should at least display a useful error, informing them that they need to log out and back in to refresh their Bugzilla session.  Other options include a login prompt or just logging them out of Review Board.  The latter is probably the least jarring, but we need to ensure that no work would be lost, particularly if it's the result of an AJAX call.

Comment 1

[Mark Côté [:mcote]]

Fixed this with a combination of a change to Review Board core (https://github.com/reviewboard/reviewboard/commit/e44360a97b01162c5a0265bb4b9f74c5fca85bc3) and rbbz (https://github.com/mozilla/rbbz/commit/b0fcb45a24d0dc44168a3a3b8b0a45e8c67ad0e1).