993232 - Mirror comments back to Bugzilla

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P1)

Description

[Mark Côté [:mcote]]

Review comments should be posted to Bugzilla.  Not sure about other changes (to description, code, etc.); we need clarification here.  Note that we need to ensure that the comment was successfully posted to Bugzilla before we approve the Review Board change so that they don't get out of sync.  A failure to write to Bugzilla should result in a failure to write to Review Board.

We are *not* mirroring comments and other changes to the Bugzilla bug back to Review Board.

Also, to avoid getting duplicated emails, email from Review Board should be disabled when this is implemented.  (Note this implies that we will write all changes to Bugzilla, probably as comments, where they would have generated Review Board email).

Comment 1

[David Lawrence [:dkl]]

(In reply to Mark Côté ( :mcote ) from comment #0)
> Also, to avoid getting duplicated emails, email from Review Board should be
> disabled when this is implemented.  (Note this implies that we will write
> all changes to Bugzilla, probably as comments, where they would have
> generated Review Board email).

If we are storing the bug id associated with a review in RB, then we could maybe only send email from RB if no bug id is associated? 

dkl

Comment 2

[Mark Côté [:mcote]]

I *think* we're always going to want a bug ID.  Plus doing something clever like that would require more work than just disabling email. :)

Comment 3

[Steven MacLeod [:smacleod]]

Attachment: Pull Request - Post bugzilla comment on review publish

Comment 4

[Mark Côté [:mcote]]

Comment on attachment 8432486 [details] [review]
Pull Request - Post bugzilla comment on review publish

Sweet, thanks!

Comment 5

[Mark Côté [:mcote]]

This is done and deployed to reviewboard-dev.