993265 - Bug 990533 made livemarks and special folders show the placeholder favicon

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Matthew N. [:MattN]]

Adding :not(#home-button) to .bookmark-item increased the specificity of the selector the amount of an ID selector (yes, this is unfortunately how :not works).

This overrode selectors like .bookmark-item[container][livemark] and the ones for special Places search folders (I'm not sure of the name) e.g. "Most Visited" which don't contain an ID. The "Bookmarks Toolbar" icon in the menu is also affected. I would recommend using another approach that avoids :not(#home-button) such as making the #home button selector use !important or just more specific.

P3- since "Most Visited" is on the bookmark toolbar by default and we used to ship a livemark by default (perhaps not anymore) so it's in primary UI on the bookmark toolbar for many users.

Comment 1

[:Gijs (he/him)]

Why is this all/all? AIUI only Linux is affected, is that right?

Comment 2

[Mike de Boer [:mikedeboer]]

This is MacOSX only, as is bug 990533.

Comment 3

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: preserve bookmark folder icons

Comment 4

[Mike de Boer [:mikedeboer]]

Thanks!

Pushed to fx-team as https://hg.mozilla.org/integration/fx-team/rev/fc36dfbc7a4e

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fc36dfbc7a4e

Comment 6

[Mike de Boer [:mikedeboer]]

Comment on attachment 8403224 [details] [diff] [review]
Patch v1: preserve bookmark folder icons

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 990533
User impact if declined: Keeps the bookmark folder icons in-tact, also makes it so that we can uplift bug 990533 to aurora & beta.
Testing completed (on m-c, etc.): landed on m-c.
Risk to taking this patch (and alternatives if risky): minor.
String or IDL/UUID changes made by this patch: n/a.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/3228aeb355ee

Beta: https://hg.mozilla.org/releases/mozilla-beta/rev/32d5b6ea4a64

Comment 9

[Andrei Vaida [:avaida]]

I was able to confirm the fix for this issue on Mac OS X 10.9 [1], using:
* the latest Beta (Build ID: 20140410150427),
* Aurora 2014-04-11 (Build ID: 20140411004002),
* Nightly 2014-04-11 (Build ID: 20140411030201).

1. Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0