Closed
Bug 993299
Opened 10 years ago
Closed 10 years ago
Australis - There is no minimum width set in customization mode
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
VERIFIED
FIXED
Firefox 31
People
(Reporter: noni, Assigned: jaws)
References
Details
(Whiteboard: [Australis:P3])
Attachments
(1 file)
799 bytes,
patch
|
mconley
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
This bug was filled as a follow up from bug 952191 (com 7). STR: 1. Open Firefox. 2. Enter Customization mode. 3. Make the browser window as small as you can. 4. Customize the browser. Results: Customization mode can't be used if the window is too small. There is no browser minimum width in the Customization mode.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8403401 -
Flags: review?(mconley)
Comment 2•10 years ago
|
||
Comment on attachment 8403401 [details] [diff] [review] Patch Easy peasy.
Attachment #8403401 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 3•10 years ago
|
||
2:04.21 INFO TEST-START | Shutdown 2:04.21 Browser Chrome Test Summary 2:04.21 Passed: 1715 2:04.21 Failed: 0 2:04.21 Todo: 0
Keywords: checkin-needed
Assignee | ||
Updated•10 years ago
|
Whiteboard: [Australis:P3]
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/215a4e3e1471
Keywords: checkin-needed
Whiteboard: [Australis:P3] → [Australis:P3][fixed-in-fx-team]
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/215a4e3e1471
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P3][fixed-in-fx-team] → [Australis:P3]
Target Milestone: --- → Firefox 31
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8403401 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): missed this case in bug 897160 User impact if declined: customization mode window can be too small to be useful Testing completed (on m-c, etc.): on m-c for a couple days now Risk to taking this patch (and alternatives if risky): none expected String or IDL/UUID changes made by this patch: none
Attachment #8403401 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•10 years ago
|
Attachment #8403401 -
Flags: approval-mozilla-beta?
Updated•10 years ago
|
Attachment #8403401 -
Flags: approval-mozilla-beta?
Attachment #8403401 -
Flags: approval-mozilla-beta+
Attachment #8403401 -
Flags: approval-mozilla-aurora?
Attachment #8403401 -
Flags: approval-mozilla-aurora+
Updated•10 years ago
|
Comment 7•10 years ago
|
||
Aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/04c8185cf050 Beta: https://hg.mozilla.org/releases/mozilla-beta/rev/3537a7b4b992
Reporter | ||
Comment 8•10 years ago
|
||
Verified fixed on Windows 7 64bit, Ubuntu 12.04 and Mac OS X 10.9 using: # latest Nightly, build ID: 20140413030203 # latest Aurora, build ID: 20140413004003.
Reporter | ||
Comment 9•10 years ago
|
||
Also verified on Fx 29 beta 8, build ID: 20140414143035.
You need to log in
before you can comment on or make changes to this bug.
Description
•