993299 - Australis - There is no minimum width set in customization mode

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Cornel Ionce [:noni]]

This bug was filled as a follow up from bug 952191 (com 7).

STR:
1. Open Firefox.
2. Enter Customization mode.
3. Make the browser window as small as you can.
4. Customize the browser.

Results:
Customization mode can't be used if the window is too small.
There is no browser minimum width in the Customization mode.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8403401 [details] [diff] [review]
Patch

Easy peasy.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

 2:04.21 INFO TEST-START | Shutdown
 2:04.21 Browser Chrome Test Summary
 2:04.21        Passed: 1715
 2:04.21        Failed: 0
 2:04.21        Todo: 0

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/215a4e3e1471

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/215a4e3e1471

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8403401 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): missed this case in bug 897160
User impact if declined: customization mode window can be too small to be useful
Testing completed (on m-c, etc.): on m-c for a couple days now
Risk to taking this patch (and alternatives if risky): none expected 
String or IDL/UUID changes made by this patch: none

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/04c8185cf050


Beta: https://hg.mozilla.org/releases/mozilla-beta/rev/3537a7b4b992

Comment 8

[Cornel Ionce [:noni]]

Verified fixed on Windows 7 64bit, Ubuntu 12.04 and Mac OS X 10.9 using:
# latest Nightly, build ID: 20140413030203
# latest Aurora, build ID: 20140413004003.

Comment 9

[Cornel Ionce [:noni]]

Also verified on Fx 29 beta 8, build ID: 20140414143035.