Closed
Bug 993303
Opened 11 years ago
Closed 11 years ago
Correct the VorbisTrackEncoder::WriteLacing function.
Categories
(Core :: Audio/Video: Recording, defect)
Core
Audio/Video: Recording
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: bechen, Assigned: bechen)
Details
Attachments
(1 file, 1 obsolete file)
|
934 bytes,
patch
|
bechen
:
review+
|
Details | Diff | Splinter Review |
When I'm writing the gtest for vorbisTrackEncoder. I'm trying to write a ReadLacing fuction, I found an implementation error in VorbisTrackEncoder::WriteLacing.
The function can not handle the lacing number which is multiple of 255.
http://matroska.org/technical/specs/index.html#lacing
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8403154 -
Flags: review?(giles)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8403154 [details] [diff] [review]
bug-993303.patch
Review of attachment 8403154 [details] [diff] [review]:
-----------------------------------------------------------------
Yay tests.
Attachment #8403154 -
Flags: review?(giles) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
r=rillian
try server:
https://tbpl.mozilla.org/?tree=Try&rev=d9597d2d6dca
Attachment #8403154 -
Attachment is obsolete: true
Attachment #8405186 -
Flags: review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•