993329 - Remove inline event handlers in newTab.xul

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

When landing bug 974745 we introduced inline event handlers to newTab.xul, which we really shouldn't use anymore because they're bad style. Please always use .addEventListener() etc. for event handling.

Comment 1

[Drew Willcoxon :adw]

I don't follow.

By inline event handlers you mean

  addEventListener(event, event => {});

instead of

  addEventListener(event, this);
  ...
  handleEvent: function (event) {}?

Why is that bad style?

Re: always using .addEventListener() for event handling, what other than addEventListener do you use to handle events?

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

No, I was talking about onclick="foo.bar()" or onsubmit="foo.baz()". Inline like in "inline styles", not sure if that's the correct term.

Comment 3

[Drew Willcoxon :adw]

Gotcha, thanks.

Comment 4

[Ed Lee :Mardak]

Attachment: v1

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/integration/fx-team/rev/040440348215

qa- for already covered by automated tests

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/040440348215