Closed Bug 993367 Opened 11 years ago Closed 11 years ago

Keyboard has a big sync reflow when switching between keyboards

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:1.3T+, b2g-v1.3T fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)

Status:
RESOLVED FIXED
Milestone:
1.4 S5 (11apr)
Project Flags:
blocking-b2g 1.3T+
Tracking Flags:
Tracking Status
b2g-v1.3T --- fixed
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: janjongboom, Assigned: janjongboom)

References

Details

(Keywords: perf, Whiteboard: [c=effect p= s= u=tarako])

Attachments

(1 file)

Patch
46 bytes, text/x-github-pull-request
rudyl
: review+
praghunath
: approval-gaia-v1.4+
Details | Review
updateTargetWindowHeight is called when we switch keyboards. This calls two very expensive (up to 60 ms. on a Keon) sync reflows to get the dimensions of the keyboard.
Attached file Patch —
Please see my comments on GH for some info.
Assignee: nobody → janjongboom
Attachment #8403258 - Flags: review?(rlu)
blocking-b2g: --- → 1.3T?
On Tarako this (sync) reflow takes anywhere from 33 (normal) to 86 (max.) when switching between normal and alt-layout on English QWERTY without suggestions.
Blocks: 994000
blocking-b2g: 1.3T? → 1.3T+
Keywords: perf
Whiteboard: [c=effect p= s= u=]
Severity: normal → blocker
Status: NEW → ASSIGNED
OS: Mac OS X → Gonk (Firefox OS)
Priority: -- → P1
Hardware: x86 → ARM
Whiteboard: [c=effect p= s= u=] → [c=effect p= s= u=tarako]
Comment on attachment 8403258 [details] [review] Patch r=me with a question on unit testing. Jan, thanks for the great work.
Attachment #8403258 - Flags: review?(rlu) → review+
master: https://github.com/mozilla-b2g/gaia/pull/18076 checkin-needed on 1.3t
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Fabrice, how does uplifting on 1.3t and 1.4 happen? Do we have to manually uplift? As you removed the checkin-needed label.
Flags: needinfo?(fabrice)
(In reply to Jan Jongboom [:janjongboom] (Telenor) from comment #5) > Fabrice, how does uplifting on 1.3t and 1.4 happen? Do we have to manually > uplift? As you removed the checkin-needed label. You just don't have to worry about 1.3T, we do them manually. 1.3/1.4 are sheriffed.
Flags: needinfo?(fabrice)
Target Milestone: --- → 1.4 S5 (11apr)
Comment on attachment 8403258 [details] [review] Patch NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): [User impact] if declined: [Testing completed]: [Risk to taking this patch] (and alternatives if risky): [String changes made]:
Attachment #8403258 - Flags: approval-gaia-v1.4?(praghunath)
Whiteboard: [c=effect p= s= u=tarako] → [c=effect p= s= u=tarako][approval-v1.4]
Whiteboard: [c=effect p= s= u=tarako][approval-v1.4] → [c=effect p= s= u=tarako][1.4-approval-needed]
Add info for requesting 1.4 approval on patch uplift [Approval Request Comment] [Bug caused by] (feature/regressing bug #): N/A [User impact] if declined: Partner blocker for Dolphin PTR test. [Testing completed]: Yes [Risk to taking this patch] (and alternatives if risky): Don't see obvious risk on this [String changes made]:No change
Flags: needinfo?(janjongboom)
Flags: needinfo?(janjongboom)
Comment on attachment 8403258 [details] [review] Patch Taking in for 1.4 as its a partner ask
Attachment #8403258 - Flags: approval-gaia-v1.4?(praghunath) → approval-gaia-v1.4+
v1.4: https://github.com/mozilla-b2g/gaia/commit/fe612fd21389193a8e593aa718831602e5086a62
status-b2g-v1.4: affected → fixed
Whiteboard: [c=effect p= s= u=tarako][1.4-approval-needed] → [c=effect p= s= u=tarako]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: