Closed
Bug 993390
Opened 11 years ago
Closed 11 years ago
Sync reflow in toggleCandidatePanel
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
1.4 S6 (25apr)
People
(Reporter: janjongboom, Assigned: janjongboom)
References
Details
(Keywords: perf, Whiteboard: [c=effect p= s= u=])
Attachments
(1 file)
There is a sync reflow in keyboard: reflow: 26.38ms function toggleCandidatePanel, render.js line 317
Sets the scrollTop / scrollLeft.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → janjongboom
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8403263 -
Flags: review?(rlu)
|
|
Assignee | |
Updated•11 years ago
|
blocking-b2g: --- → 1.3T?
|
|
Assignee | |
Comment 2•11 years ago
|
||
You only see these if you have suggestions enabled, so probably not related for Tarako.
blocking-b2g: 1.3T? → ---
|
||
Updated•11 years ago
|
Component: Gaia::Keyboard → Gaia::System::Input Mgmt
|
|
||
Updated•11 years ago
|
Component: Gaia::System::Input Mgmt → Gaia::Keyboard
|
||
Updated•11 years ago
|
Status: NEW → ASSIGNED
OS: Mac OS X → Gonk (Firefox OS)
Priority: -- → P2
Hardware: x86 → ARM
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8403263 [details] [review]
Patch
Jan, could you add |false| to other IMERender.toggleCandidatePanel() calls, not just change the ones with |true|?
Attachment #8403263 -
Flags: review?(rlu) → feedback+
|
|
Assignee | |
Comment 4•11 years ago
|
||
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #3)
> Comment on attachment 8403263 [details] [review]
> Patch
>
> Jan, could you add |false| to other IMERender.toggleCandidatePanel() calls,
> not just change the ones with |true|?
Can you elaborate on this? Don't really get it. Maybe comment on github, makes it easier.
Flags: needinfo?(timdream)
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8403263 [details] [review]
Patch
I am sorry, I was confused and overlooked.
Attachment #8403263 -
Flags: feedback+ → review+
Flags: needinfo?(timdream)
|
|
Assignee | |
Comment 7•11 years ago
|
||
Was conference and sitting in a plane last two days.
Landed: https://github.com/mozilla-b2g/gaia/commit/e37d0820f921d2d06ac211e0b6447e0d6bcf65b3
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: needinfo?(janjongboom)
Resolution: --- → FIXED
|
|
||
Updated•10 years ago
|
Target Milestone: --- → 1.4 S6 (25apr)
You need to log in
before you can comment on or make changes to this bug.
Description
•