Closed
Bug 993410
Opened 11 years ago
Closed 11 years ago
Improve coverage of nsTArray post barriers test
Categories
(Core :: JavaScript: GC, enhancement)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(1 file)
|
4.51 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
The test code in xpcom/glue/tests/gtest/TestGCPostBarriers.cpp only exercises nsTArray itself. It can simply be extended to cover the fallible and auto versions of nsTArray.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8403280 -
Flags: review?(terrence)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8403280 [details] [diff] [review]
improve-array-tests
Review of attachment 8403280 [details] [diff] [review]:
-----------------------------------------------------------------
Nice! r=me
Did it sus out any errors?
Attachment #8403280 -
Flags: review?(terrence) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
(In reply to Terrence Cole [:terrence] from comment #2)
It didn't find any new problems. I wrote it while investigating bug 992535 and figured I might as well commit it.
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•