Closed Bug 993410 Opened 7 years ago Closed 7 years ago

Improve coverage of nsTArray post barriers test

Categories

(Core :: JavaScript: GC, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file)

The test code in xpcom/glue/tests/gtest/TestGCPostBarriers.cpp only exercises nsTArray itself.  It can simply be extended to cover the fallible and auto versions of nsTArray.
Attachment #8403280 - Flags: review?(terrence)
Blocks: 673454
Comment on attachment 8403280 [details] [diff] [review]
improve-array-tests

Review of attachment 8403280 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! r=me

Did it sus out any errors?
Attachment #8403280 - Flags: review?(terrence) → review+
(In reply to Terrence Cole [:terrence] from comment #2)

It didn't find any new problems.  I wrote it while investigating bug 992535 and figured I might as well commit it.
https://hg.mozilla.org/mozilla-central/rev/fda54da252d0
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.