993422 - Copy improvements in Email fields

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, enhancement)

Description

[Beatriz Rodríguez [:brg]]

In manual configuration of Exchange(ActiveSync) account, the option: "Username" should be changed by: "Domain\Username", this is not clear for end user, if only introduce his user name, the exchange account does not work.

Guillermo told me that:
setup-manual-username.placeholder=Usuario/a

Is shared by all the email accounts fields. In case of IMAP accounts does not make sense to have to introduce the Domain.

Can we include this modification as an improvement in the copy review?

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Yes, this would make sense in manual configuration mode since we explicitly know that we are dealing with ActiveSync.  (It doesn't make sense for hotmail.com/outlook.com, but they will correctly autoconfigure, and in any event we want to switch them to IMAP in bug 958614.)

Although we currently reuse the setup-manual-username l10n string across all username fields, ActiveSync has its own 'input' element (class 'sup-manual-activesync-username'), so it's just a question of adding a new l10n id/string and updating setup_manual_config.html to use it.

Comment 2

[Guillermo López :willyaranda (probably SLOW response)]

Attachment: Fix

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8403341 [details] [review]
Fix

(switching review to :mcav since he most recently touched the manual compose page and I know he yearns to do more e-mail reviews)

Comment 4

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8403341 [details] [review]
Fix

Sorry for the delay! I originally thought "Oh, I'll look at this as soon as I finish the commit I'm working on" and then didn't actually finish the commit when I thought I would.

Tested, looks good to me, though why ActiveSync uses such a strange name for configuration details is beyond me. I thought my days of backslashes were behind me.

Comment 6

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

Hi Andrew, since the patch already review+, could we land it on 1.3 branch?

Thanks

Vance

Comment 7

[Axel Hecht [:Pike]]

Marking this as checkin-needed, as willyaranda doesn't have permissions to push to gaia.

Re branches, this patch would break string freeze and I don't think this is branch material.

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

Ha, I was hoping to avoid bothering :Pike about this, but didn't check the cc list!

I sent an email to dev-gaia (not yet showing up in the google groups mirror for linking...) requesting that we update https://wiki.mozilla.org/Release_Management/B2G_Landing to be more clear about l10n/strings so that we don't need to bother :Pike or depend on him already being cc'ed.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/47836f8d7e7215875477b036cfab758ebf636d84

Comment 10

[Edward Chen[:edchen]]

[Environment]
Gaia      c1a8cbaac1d921cfb50e3a2600720b75cf5afabd
Gecko     https://hg.mozilla.org/mozilla-central/rev/20ca234fd62b
BuildID   20140511160202
Version   32.0a1
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013

[Result]
PASS