993512 - [B2G][Camera] Retaking a photo will briefly display previously taken image

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Tony Nguyen]

Attachment: logcat

Description:
The Camera will briefly display the image that was taken before it when the user attempts to retake a photo. 

Repro Steps:
1) Update Buri to BuildID: 20140408000202
2) Tap and hold on the homescreen
3) Tap on 'Change Wallpaper'
4) Tap on 'Camera'
5) Take a photo 
6) When a preview is displayed, tap on Retake
7) Take another photo

Actual:
The first photo that was taken will momentarily be displayed before showing preview to the new photo

Expected:
The first photo that was taken doesn't appear on screen

Environmental Variables:
Device: Buri v1.4 mozRIL
BuildID: 20140408000202
Gaia: 26983f356ecb1bcf30e862d334b5de790071803e
Gecko: 70b076fc7558
Version: 30.0a2
Firmware Version: v1.2-device.cfg

Notes:
Repro frequency: 5/5 - 100%
See attached: logcat
URL: http://youtu.be/syNadbjMvMQ

Comment 1

[Tony Nguyen]

This issue does not reproduce on the latest Buri v1.3 mozRIL BuildID: 20140408004002. 

Gaia: 0a7a50129995f080c1df4d807a2334701701e8ed
Gecko: e3fca8c23e1d
Version: 28.0
Firmware Version: v1.2-device.cfg

Comment 2

[Tony Nguyen]

This issue does reproduce on 03/26 Buri mozRIL BuildID: 20140326000201.

Gaia: 7e705dd4718d528974d99ac31866318d7e201152
Gecko: 4889124accfa
Version: 30.0a2
Firmware Version: v1.2-device.cfg

Comment 3

[Jason Smith [:jsmith]]

On one hand the functionality works here, but on the other hand this looks like a really ugly picture taking animation for retaking pictures.

Hema - What's your thoughts on the priority of this bug? I'm debating on nominating it, but I'd like a second opinion.

Comment 4

[Hema Koka [:hema]]

Agree that the experience does not look good, plus we have regressed it from previous release.

There is no broken functionality, but would be good to get this addressed. I am not making it a blocker but will add it to the priority stack after blockers are fixed.

Thanks
Hema

Comment 5

[Justin D'Arcangelo [:justindarc]]

Attachment: pull-request (master)

David: This should probably be flagged 1.4+

Tif: Again, I wasn't sure if this should be ui-review'd by amylee as well, if so, please add her. Thanks!

Comment 6

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8405588 [details] [review]
pull-request (master)

I don't see any flashing of previous pic as stated in the STR. Seems good.

Comment 7

[David Flanagan [:djf]]

Comment on attachment 8405588 [details] [review]
pull-request (master)

r+: this is a simple, safe patch and the code is clearly correct, by inspection. Tif has run it and verified that it works as it should.

This is not a blocker, but is a trivial patch for a pretty bad user experience, so giving a+ for uplift to 1.4

Comment 8

[David Flanagan [:djf]]

Landed on master: https://github.com/mozilla-b2g/gaia/commit/4ffb7c8cb330fc22cba938223443f056c7bc03b8

Comment 9

[David Flanagan [:djf]]

Uplifted to v1.4: https://github.com/mozilla-b2g/gaia/commit/51ff8dfe2765acdfb5b5cd853c5f6c032f129540