993533 - Add remote add-ons to the list of targets on a remote device

Status: VERIFIED FIXED

Description

[Dave Townsend [:mossop] (he/him)]

The connection screen should list remote add-ons that can be debugged

Comment 1

[Girish Sharma [:Optimizer]]

wow. this would be something !!

Comment 2

[Dave Townsend [:mossop] (he/him)]

Very simple but it's going to depend on bug 993029 landing first

Comment 3

[Philipp Kewisch [:Fallen] [:📆]]

I was waiting for this one to be filed, it was just a matter of time :-) Thanks!

Comment 4

[Dave Townsend [:mossop] (he/him)]

Attachment: patch

Fairly straightforward. Are there any tests for the connection screen?

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8405489 [details] [diff] [review]
patch

Review of attachment 8405489 [details] [diff] [review]:
-----------------------------------------------------------------

Moving this along to Panos since I think he wrote the connection stuff. I haven't ever even looked at this code :-/

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8405489 [details] [diff] [review]
patch

Review of attachment 8405489 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't test Fennec, but I assume you have. Desktop works fine, except for the missing check for non-debuggable add-ons.

We don't have any tests for the remote connection screen, sadly. It also might go away at some point in the (distant) future, if we can turn the App Manager into a viable replacement for all use cases.

::: browser/devtools/framework/connect/connect.js
@@ +88,5 @@
> +  if (!response.error && response.addons.length > 0) {
> +    // Add one entry for each add-on.
> +    for (let addon of response.addons) {
> +      //if (!addon.isDebuggable)
> +      //  continue;

You probably meant to uncomment this and test for !addon.debuggable?

Comment 7

[Dave Townsend [:mossop] (he/him)]

Uhh yes. https://hg.mozilla.org/integration/fx-team/rev/67c1405cd110

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/67c1405cd110

Comment 9

[Petruta Rasa [Away. Please needinfo? [e-mail]]]

Dave, what are the steps to do in order to verify this bug as fixed?

For Desktop, Past helped me to open "Console - about:addons" window by using two FF instances, starting the debugger server (with listen 6000 in Developer Toolbar) and then selecting Connect in chrome://browser/content/devtools/connect.xhtml. In this window I can debug the about:addons page, but not an individual add-on installed. How could I do this?

For Fennec, I can see the "Available remote add-ons:" option on latest Firefox beta available on Play Store. Selecting the add-on that I installed on device, opens a new window (Web Console like) containing only Toolbox Options and Debugger tabs. Should I check anything else here?

Thank you!

Comment 10

[Dave Townsend [:mossop] (he/him)]

You have just verified it(In reply to Petruta Rasa [QA] [:petruta] from comment #9)
> Dave, what are the steps to do in order to verify this bug as fixed?
> 
> For Desktop, Past helped me to open "Console - about:addons" window by using
> two FF instances, starting the debugger server (with listen 6000 in
> Developer Toolbar) and then selecting Connect in
> chrome://browser/content/devtools/connect.xhtml. In this window I can debug
> the about:addons page, but not an individual add-on installed. How could I
> do this?

Did you have chrome debugging enabled in the Firefox you were connecting to?

> For Fennec, I can see the "Available remote add-ons:" option on latest
> Firefox beta available on Play Store. Selecting the add-on that I installed
> on device, opens a new window (Web Console like) containing only Toolbox
> Options and Debugger tabs. Should I check anything else here?

That's fine

Comment 11

[Petruta Rasa [Away. Please needinfo? [e-mail]]]

Thanks! I managed to verify it on desktop side too using Firefox 31 RC under Win 7 64-bit, Ubuntu 13.04 32-bit and Mac OSX 10.9.4. The same window as on device was opened on the second Firefox instance containing the debugger of the add-on.