Closed
Bug 993533
Opened 11 years ago
Closed 11 years ago
Add remote add-ons to the list of targets on a remote device
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(firefox31 verified)
VERIFIED
FIXED
Firefox 31
Tracking | Status | |
---|---|---|
firefox31 | --- | verified |
People
(Reporter: mossop, Assigned: mossop)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
9.68 KB,
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
The connection screen should list remote add-ons that can be debugged
Comment 1•11 years ago
|
||
wow. this would be something !!
Assignee | ||
Comment 2•11 years ago
|
||
Very simple but it's going to depend on bug 993029 landing first
Assignee: nobody → dtownsend+bugmail
Depends on: 993029
Comment 3•11 years ago
|
||
I was waiting for this one to be filed, it was just a matter of time :-) Thanks!
Assignee | ||
Comment 4•11 years ago
|
||
Fairly straightforward. Are there any tests for the connection screen?
Attachment #8405489 -
Flags: review?(nfitzgerald)
Comment 5•11 years ago
|
||
Comment on attachment 8405489 [details] [diff] [review]
patch
Review of attachment 8405489 [details] [diff] [review]:
-----------------------------------------------------------------
Moving this along to Panos since I think he wrote the connection stuff. I haven't ever even looked at this code :-/
Attachment #8405489 -
Flags: review?(nfitzgerald) → review?(past)
Comment 6•11 years ago
|
||
Comment on attachment 8405489 [details] [diff] [review]
patch
Review of attachment 8405489 [details] [diff] [review]:
-----------------------------------------------------------------
I didn't test Fennec, but I assume you have. Desktop works fine, except for the missing check for non-debuggable add-ons.
We don't have any tests for the remote connection screen, sadly. It also might go away at some point in the (distant) future, if we can turn the App Manager into a viable replacement for all use cases.
::: browser/devtools/framework/connect/connect.js
@@ +88,5 @@
> + if (!response.error && response.addons.length > 0) {
> + // Add one entry for each add-on.
> + for (let addon of response.addons) {
> + //if (!addon.isDebuggable)
> + // continue;
You probably meant to uncomment this and test for !addon.debuggable?
Attachment #8405489 -
Flags: review?(past) → review+
Assignee | ||
Comment 7•11 years ago
|
||
Comment 8•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
status-firefox31:
--- → fixed
Comment 9•11 years ago
|
||
Dave, what are the steps to do in order to verify this bug as fixed?
For Desktop, Past helped me to open "Console - about:addons" window by using two FF instances, starting the debugger server (with listen 6000 in Developer Toolbar) and then selecting Connect in chrome://browser/content/devtools/connect.xhtml. In this window I can debug the about:addons page, but not an individual add-on installed. How could I do this?
For Fennec, I can see the "Available remote add-ons:" option on latest Firefox beta available on Play Store. Selecting the add-on that I installed on device, opens a new window (Web Console like) containing only Toolbox Options and Debugger tabs. Should I check anything else here?
Thank you!
Flags: needinfo?(dtownsend+bugmail)
Assignee | ||
Comment 10•11 years ago
|
||
You have just verified it(In reply to Petruta Rasa [QA] [:petruta] from comment #9)
> Dave, what are the steps to do in order to verify this bug as fixed?
>
> For Desktop, Past helped me to open "Console - about:addons" window by using
> two FF instances, starting the debugger server (with listen 6000 in
> Developer Toolbar) and then selecting Connect in
> chrome://browser/content/devtools/connect.xhtml. In this window I can debug
> the about:addons page, but not an individual add-on installed. How could I
> do this?
Did you have chrome debugging enabled in the Firefox you were connecting to?
> For Fennec, I can see the "Available remote add-ons:" option on latest
> Firefox beta available on Play Store. Selecting the add-on that I installed
> on device, opens a new window (Web Console like) containing only Toolbox
> Options and Debugger tabs. Should I check anything else here?
That's fine
Flags: needinfo?(dtownsend+bugmail)
Comment 11•11 years ago
|
||
Thanks! I managed to verify it on desktop side too using Firefox 31 RC under Win 7 64-bit, Ubuntu 13.04 32-bit and Mac OSX 10.9.4. The same window as on device was opened on the second Firefox instance containing the debugger of the add-on.
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•