Closed Bug 993633 Opened 9 years ago Closed 9 years ago

Add better failure handling in CastingApps.openExternal

Categories

(Firefox for Android Graveyard :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 31

People

(Reporter: mfinkle, Unassigned)

References

Details

Attachments

(1 file)

This patch adds some checks to make sure the casting app actually starts before proceeding.

It also switches "video" to "element" in the video meta data. This is what the rest of the code expects and is why the "pause when starting to cast a video" is currently broken.
Attachment #8403511 - Flags: review?(wjohnston)
Comment on attachment 8403511 [details] [diff] [review]
casting-bugs v0.1

Review of attachment 8403511 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/content/CastingApps.js
@@ +239,5 @@
>  
>        app.stop(function() {
> +        app.start(function(aStarted) {
> +          if (!aStarted) {
> +            return;

This seems like a good place to log something.

@@ +246,3 @@
>            app.remoteMedia(function(aRemoteMedia) {
> +            if (!aRemoteMedia) {
> +              return;

and here :)
Attachment #8403511 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/mozilla-central/rev/f1ee03965af4
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.