993633 - Add better failure handling in CastingApps.openExternal

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: casting-bugs v0.1

This patch adds some checks to make sure the casting app actually starts before proceeding.

It also switches "video" to "element" in the video meta data. This is what the rest of the code expects and is why the "pause when starting to cast a video" is currently broken.

Comment 1

[Wesley Johnston (:wesj)]

Comment on attachment 8403511 [details] [diff] [review]
casting-bugs v0.1

Review of attachment 8403511 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/content/CastingApps.js
@@ +239,5 @@
>  
>        app.stop(function() {
> +        app.start(function(aStarted) {
> +          if (!aStarted) {
> +            return;

This seems like a good place to log something.

@@ +246,3 @@
>            app.remoteMedia(function(aRemoteMedia) {
> +            if (!aRemoteMedia) {
> +              return;

and here :)

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Logging added:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1ee03965af4

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f1ee03965af4