Closed
Bug 993706
Opened 11 years ago
Closed 11 years ago
Remove nsGlobalWindow::mInnerWindowHolder
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: peterv, Assigned: peterv)
References
Details
Attachments
(1 file)
|
9.52 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
It's a nsIXPConnectJSObjectHolder, so it can't store the WebIDL object. It's not really needed though, the inner is kept alive by the outer proxy as its target. The WindowStateHolder can just hold the inner nsGlobalWindow and preserve its wrapper.
Attachment #8403587 -
Flags: review?(bzbarsky)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8403587 [details] [diff] [review]
v1
>- MOZ_ASSERT(aNewInner->GetWrapperPreserveColor());
Maybe assert that aNewInner->GetWrapperPreserveColor() == aGlobal?
r=me
Attachment #8403587 -
Flags: review?(bzbarsky) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•