993706 - Remove nsGlobalWindow::mInnerWindowHolder

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Peter Van der Beken [:peterv]]

Attachment: v1

It's a nsIXPConnectJSObjectHolder, so it can't store the WebIDL object. It's not really needed though, the inner is kept alive by the outer proxy as its target. The WindowStateHolder can just hold the inner nsGlobalWindow and preserve its wrapper.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8403587 [details] [diff] [review]
v1

>-  MOZ_ASSERT(aNewInner->GetWrapperPreserveColor());

Maybe assert that aNewInner->GetWrapperPreserveColor() == aGlobal?

r=me

Comment 2

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/915bf0a150a4

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/915bf0a150a4