Closed
Bug 993734
Opened 11 years ago
Closed 11 years ago
The observer service should not pretend to be threadsafe
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: khuey, Assigned: khuey)
References
Details
Attachments
(1 file)
|
1.20 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
We need to remove the threadsafe refcounting and add hard aborts to the functions.
|
Assignee | |
Comment 1•11 years ago
|
||
Comment on attachment 8403657 [details] [diff] [review]
0009-Bug-993734-Stop-pretending-that-the-observer-service.patch
I approve, but bsmedberg should probably sign off on this.
Attachment #8403657 -
Flags: review?(dbaron) → review?(benjamin)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8403657 [details] [diff] [review]
0009-Bug-993734-Stop-pretending-that-the-observer-service.patch
This used to be threadsafe-refcounting because people were using it via XPCOM proxies. We don't have those any more \o/
Attachment #8403657 -
Flags: review?(benjamin) → review+
|
||
Comment 4•11 years ago
|
||
Backed out because bug 995405 was backed out and I assume hilarity would have ensued otherwise.
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2cf132023be
|
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•