Closed Bug 993734 Opened 9 years ago Closed 9 years ago

The observer service should not pretend to be threadsafe

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla31

People

(Reporter: khuey, Assigned: khuey)

References

Details

Attachments

(1 file)

0009-Bug-993734-Stop-pretending-that-the-observer-service.patch
1.20 KB, patch
benjamin
: review+
Details | Diff | Splinter Review 
We need to remove the threadsafe refcounting and add hard aborts to the functions.
Assignee: nobody → khuey
Status: NEW → ASSIGNED

        Attachment #8403657 -
        Flags: review?(dbaron)

    
    

    
  
Comment on attachment 8403657 [details] [diff] [review]
0009-Bug-993734-Stop-pretending-that-the-observer-service.patch

I approve, but bsmedberg should probably sign off on this.

        Attachment #8403657 -
        Flags: review?(dbaron) → review?(benjamin)

    
    

    
  
Comment on attachment 8403657 [details] [diff] [review]
0009-Bug-993734-Stop-pretending-that-the-observer-service.patch

This used to be threadsafe-refcounting because people were using it via XPCOM proxies. We don't have those any more \o/

        Attachment #8403657 -
        Flags: review?(benjamin) → review+

    
    

    
  
Backed out because bug 995405 was backed out and I assume hilarity would have ensued otherwise.
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2cf132023be

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/04c91d627ba3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31

    
  
Depends on: 1005336

          You need to log in
          before you can comment on or make changes to this bug.