Closed Bug 993786 Opened 11 years ago Closed 11 years ago

update_crash_adu_by_build_signature() does not check for valid build ID

Categories

(Socorro :: Database, task)

Product:
Socorro
Component:
Database
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rhelmer, Assigned: rhelmer)

Details

(Whiteboard: [DBChanges])

We are letting in crashes right now that don't have a valid-looking build ID, for example: https://crash-stats.mozilla.com/report/index/acf14d6d-af72-4a68-a073-cae2e2140407 This is tripping up the update_crash_adu_by_build_signature() SP because it's trying to parse that into a date: source string too short for "YYYY" formatting field DETAIL: Field requires 4 characters, but only 1 remain. HINT: If your source string is not fixed-width, try using the "FM" modifier. Note that the build ID is "2" in the crash above, no way we're going to sensibly parse that :) We might as well ignore anything with a build ID under length(8)
Selena, should update_reports_clean() be letting in crashes that have build IDs that we've never seen in e.g. releases_raw? I thought it shouldn't but reading over update_reports_clean() and update_product_versions() I guess we're not being that restrictive?
Flags: needinfo?(sdeckelmann)
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/5a8c4d01f0ebec7f26df66659337660902024b3c bug 993786 - update_crash_adu_by_build_signature() should handle bad build IDs https://github.com/mozilla/socorro/commit/d2e1ea234cc8da7c01cb1538a6dffec632772d0b Merge pull request #1985 from rhelmer/bug993786-update_crash_adu_by_build_signature-bad-buildids bug 993786 - update_crash_adu_by_build_signature() should handle bad bui...
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Actually this needs a migration - we need to reload that stored procedure.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
PR for migration: https://github.com/mozilla/socorro/pull/1986
Whiteboard: [DBChanges]
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/2a54d2a54431dad901c0520617c8913da7173893 bug 993786 - migration for update_crash_adu_by_build_signature https://github.com/mozilla/socorro/commit/26a90f832924d3f11ba757de9fee0fdb3e46698c Merge pull request #1986 from rhelmer/bug993786-update_crash_adu_by_build_signature-bad-buildids bug 993786 - migration for update_crash_adu_by_build_signature
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/11127ae2a256b11e13366c8b20fb28a275e95dc2 bug 993786 - use sensible signature name for test https://github.com/mozilla/socorro/commit/22dbdce3e44227147fbeef9704d2f11d65d24c2b Merge pull request #1995 from rhelmer/bug993786-use-sensible-signature-for-test bug 993786 - use sensible signature name for test
Target Milestone: --- → 81
Target Milestone: 81 → 82
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Flags: needinfo?(sdeckelmann)
You need to log in before you can comment on or make changes to this bug.