993817 - Rewrite mobilemessage marionette test cases with Promise

Status: RESOLVED INCOMPLETE

(Firefox OS Graveyard :: RIL, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

+++ This bug was initially created as a clone of Bug #979134 +++

Let's reuse http://dxr.mozilla.org/mozilla-central/source/dom/mobilemessage/tests/marionette/head.js whenever possible.

Comment 1

[Ken Chang[:kenkai]]

Put this bug into backlog.

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch

1) Fix:
* test_emulator_loopback.js
* test_filter_date.js
* test_getmessage.js
* test_getmessage_notfound.js
* test_getmessages.js
* test_incoming.js
* test_outgoing.js
2) merge test_filter_date_notfound.js into test_filter_date.js
3) merge test_incoming_multipart.js into test_incoming.js

Not _all_ SMS test cases are converted, just some done works so far.

Comment 3

[Gene Lian (I already quit Mozilla)]

Comment on attachment 8444301 [details] [diff] [review]
patch

Review of attachment 8444301 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mobilemessage/tests/marionette/test_getmessage_notfound.js
@@ +17,5 @@
> +      let error = aEvent.target.error;
> +      ok(error, "DOMError");
> +      is(error.name, "NotFoundError", "error.name");
> +    });
> +}  

nit: trailing spaces.

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch : v2

Address previous nit only.

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch : v3

Document pushPrefEnv() only.

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/b2g-inbound/rev/be39010d4f5e

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/be39010d4f5e