Closed Bug 993835 Opened 6 years ago Closed 6 years ago

Added Makefile for keyboard back

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S6 (25apr)

People

(Reporter: yurenju, Assigned: yurenju)

Details

Attachments

(1 file)

we did a workaround for build.js in keyboard app to remove Makefile on bug 897352, but Makefile should exist to handle different copy rule for keyboard layout customization.

so let's add it back.
tested on Windows & Linux and works fine.
Comment on attachment 8403758 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/18098

Rudy, could you give some feedback for this pull request?
Attachment #8403758 - Flags: feedback?(rlu)
Comment on attachment 8403758 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/18098

Yuren,

Thanks for the modification. 
I'm fine with this with a question on pr.
Attachment #8403758 - Flags: feedback?(rlu) → feedback+
In copyStaticFiles function of build.js, we also copy latin related script into stage. I think we should handle them in same place.

We already handle the copy task inside copyStaticFiles of build.js, so we probably only need clean task.
What do you think?
yeah you're right, pull request will be updated, thanks!
Assignee: nobody → yurenju.mozilla
Comment on attachment 8403758 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/18098

Hi George, pr is updated, could you review again? thanks!
Attachment #8403758 - Flags: review?(gduan)
Comment on attachment 8403758 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/18098

It looks fine to me. r=gduan
Thanks.
Attachment #8403758 - Flags: review?(gduan) → review+
merged, thanks!
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S6 (25apr)
You need to log in before you can comment on or make changes to this bug.