99391 - [Regression]Display name is not entered into the Address Book

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[marina]

*** observed with 2001-09-12-03-0.9.4 build ***
Steps to reproduce:
- create an AB card where you enter a Display name,email address etc wihtout
filling out First and Last name;
- click Ok to submit the new card to the AB;
//note: no display name in the thread
to repro it differently you can select a message, rightclick on the Freom field
and click Add to Address Book, then observe that no Display name is showing up
in the AB

Comment 1

[marina]

this bug causes a lot of inconvinience: after you click "Add to AB" you expect
to see the Display name entered as well ( and that's the way it worked before,
this is a regression) but you have to search by the email address instead. The
Collected adressses is functionning correctly meaning collecting from
incoming/outgoing mails the display name and the email address

Comment 2

[John Marmion]

See also bug 101145. This function "top.DisplayNameChanged()" in
abCardOverlay.xul is not found on input into the text field DisplayName. Calling
"DisplayNameChanged()" on its own is found.

Comment 3

[marina]

This is a regression from the previous funtionality, are we planning to fix this? 

Comment 4

[Ninoschka Baca]

Marking duplicate of bug# 101145 since that bug discusses a possible fix.

*** This bug has been marked as a duplicate of 101145 ***

Comment 5

[Ninoschka Baca]

Verified Duplicate.

Comment 6

[Ninoschka Baca]

Reopening, since this bug refers to entering only a Display name and not a
First/Last name so it is different then bug# 101145.

Comment 7

[lchiang]

cc: mscott - do you think this is a common case?

Comment 8

[John Marmion]

Attachment: Patch to fix 99391 and 101145

Comment 9

[John Marmion]

I posted a solution to this a number of days ago but nobody picked up on it. So
I am sending in the patch that fixes this and bug 101145. 

Comment 10

[Scott MacGregor]

thanks for the fix John. I'll get it into the trunk today for testing. then
we'll get approval tomorrow for the  branch.

Comment 11

[Jaime Rodriguez, Jr.]

Pls update patch status with "has review"

check it in - PDT+

Comment 12

[(not reading, please use [e-mail] instead)]

Comment on attachment 51064 [details] [diff] [review]
Patch to fix 99391 and 101145

r=sspitzer

Comment 13

[Scott MacGregor]

checked into the trunk. Once we verify this works in the trunk in tomorrow's
builds, I'll check it into the branch. 

Comment 14

[Scott MacGregor]

*** Bug 101145 has been marked as a duplicate of this bug. ***

Comment 15

[Ninoschka Baca]

Trunk build 2001-09-28-05: WinMe
Trunk build 2001-09-28-04: Linux RH 7.1
Trunk build 2001-09-28-03: Mac 9.01
Fixed on the trunk.

Comment 16

[Scott MacGregor]

Thanks for the quick turn around Ninoshka!

Comment 17

[Scott MacGregor]

Oops didn't realize this was already plussed. I'm just going to check it on in.
Checked in on the branch too.

Comment 18

[Ninoschka Baca]

Branch build 2001-10-01-05: WinMe
Branch build 2001-10-01-04: Mac 9.1
Branch build 2001-10-01-03: Linux RH 7.1
Verified Fixed.

- Created a new AB Card by entering a Display name but not the First and Last
name. The Display name appears in the PAB, as expected.
- In the Message pane, right clicked onto an email address, selected Add To
Address Book and it correctly adds the Display name and the email address and
the Display name appears in the PAB, as expected.

Comment 19

[marina]

This works only with a new profile, it doesn't work with an exsiting one. Do we
have to delete some files to make it work?