Closed
Bug 993913
Opened 11 years ago
Closed 11 years ago
remove the %user_cache from inline history, and ensure the object cache is always used
Categories
(bugzilla.mozilla.org Graveyard :: Extensions: InlineHistory, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: glob, Assigned: dylan)
Details
(Keywords: perf)
Attachments
(1 file)
|
1.23 KB,
patch
|
dkl
:
review+
dkl
:
feedback+
|
Details | Diff | Splinter Review |
inline history maintains its own cache of user objects, however this is no longer required since the object cache was introduced.
- remove %user_cache completely from Extension.pm
- update the Bugzilla::User->new() call to use the cache
|
Assignee | |
Updated•11 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → dylan
|
|
Assignee | |
Comment 1•11 years ago
|
||
Is this what you had in mind? Nothing is ever this simple...
Attachment #8404281 -
Flags: feedback?(glob)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8404281 [details] [diff] [review]
bug-993913-v1.patch
Looks correct to to me.
Attachment #8404281 -
Flags: feedback+
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8404281 -
Flags: review?(dkl)
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8404281 [details] [diff] [review]
bug-993913-v1.patch
Review of attachment 8404281 [details] [diff] [review]:
-----------------------------------------------------------------
r=dkl
Attachment #8404281 -
Flags: review?(dkl)
Attachment #8404281 -
Flags: review+
Attachment #8404281 -
Flags: feedback?(glob)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Committed 43572df
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: bugzilla.mozilla.org → bugzilla.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•