993926 - Bugzilla::User::Setting::get_all_settings() should use memcached

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement, P1)

Description

[:glob ✱]

due to the gravatar extension on BMO, $user->settings() is called for each commenter.  this results in frequent database calls for data that changes very infrequently, making it an ideal candidate for memcached.

changes required:
- during an update in editsettings.cgi call Bugzilla->memcached->clear_config()
- update Bugzilla::User::Settings:
  - update get_all_settings($user_id)
    - build a cache key as "user_settings.$user_id"
    - check the cache with Bugzilla->memcached->get_config($key) and return if found
    - if not found, query the database and store with memcached->set_config()
  - add a method clear_settings_cache($user_id)
    - calls memcached->clear({ key => $key }) using the same key as get_all_settings()
- call clear_settings_cache() from userprefs.cgi::SaveSettings()

i'm not totally comfortable with clear_settings_cache(), however the way settings have been implemented makes abstraction difficult (the settings hashref inside the user object is updated directly by userprefs.cgi, and using a tied hashref would be an overkill).

Comment 1

[:glob ✱]

Attachment: 993926_1.patch

Comment 2

[:glob ✱]

To ssh://[e-mail]/bugzilla/bugzilla.git
   8b98912..c19dc4f  master -> master