Closed Bug 993935 Opened 6 years ago Closed 4 years ago

[keyboard refactor] layout manager should abort the loading of previous layout when there is a second one

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: timdream, Unassigned)

References

Details

+++ This bug was initially created as a clone of Bug #956175 +++

I didn't review this patch correctly. The behavior described by this unit test is incorrect.

https://github.com/mozilla-b2g/gaia/commit/4645b8da5a9cf25795313b20a56bad67225786c5#diff-b4732e6601b789fba0e97cd98df1b096R68

The handleLayoutLoaded() should not be called twice when the layout to handle is not the last one being called.

We can also make KeyboardApp check it's currentLayoutName instead. Rudy, what do you think?
Flags: needinfo?(rlu)
Yes, I also consider the API behavior as you said when writing this part of code, but at the end, I chose to make the API respond with handleLayoutLoaded() each time when the client code request a layout.
I think the client should control the calling of layoutManager.call() and handle handleLayoutLoaded() accordingly.

Please let me know if you have any other suggestions.
Flags: needinfo?(rlu)
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.