993939 - Bugzilla::User::Setting::groups() should use memcached

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[:glob ✱]

$user->groups() is called for each commenter in a bug.  this results in frequent database calls for data that changes very infrequently, making it an ideal candidate for memcached.

implementation notes:
- in Bugzilla::User::groups() 
  - build a cache key "user_groups.$user_id"
  - wrap the db check and tree walking with memcached->get_config and set_config (follow how $membership_rows is cached)
- in Bugzilla::User::update()
  - call memcached->clear_config({ key => "user_groups.$user_id" }) if login_name changed
- in editusers.cgi
  - call memcached->clear_config({ key => "user_groups.$user_id" }) if $action is update

Comment 1

[:glob ✱]

Attachment: 993939_1.patch

- stores and checks a user's group membership in memcached
- extends memcached->clear_config to support clearing individual keys
- clears the cached value in $user->derive_regexp_groups()
- clears the cached value in edituser when groups membership is changed
- changes memcached's prefix delimiter from : to . to avoid escaping, making keys easier to read when debugging

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 8415777 [details] [diff] [review]
993939_1.patch

Review of attachment 8415777 [details] [diff] [review]:
-----------------------------------------------------------------

Works as expected. r=dkl

Comment 3

[:glob ✱]

To ssh://[e-mail]/bugzilla/bugzilla.git
   ccff248..6d730fa  master -> master

Comment 4

[:glob ✱]

this broke the build:
https://travis-ci.org/bugzilla/bugzilla/jobs/26188673
Can't call method "get" on an undefined value at Bugzilla/Memcached.pm line 187.

Comment 5

[:glob ✱]

To ssh://[e-mail]/bugzilla/bugzilla.git
   6d730fa..b5b5061  master -> master