Closed Bug 993944 Opened 10 years ago Closed 10 years ago

[DIaler][Messages] Unify the use of the async storage mock

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Dialer
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: julienw, Assigned: julienw)

References

Details

Attachments

(1 file)

github PR
46 bytes, text/x-github-pull-request
steveck
: review+
rik
: review+
Details | Review 
Dialer's unit test are using the async storage mock from the SMS app, which make it fail when run in B2G Desktop.
Attached file github PR — 
Waiting for a travis run before asking a review
Comment on attachment 8403842 [details] [review]
github PR

review? from Rik for the Dialer part and Steve for the SMS part.

There is also an async storage in Settings but it's less dumb and I thought rewriting these tests for something I don't know was out of scope for this bug.
Attachment #8403842 - Flags: review?(schung)
Attachment #8403842 - Flags: review?(anthony)
Comment on attachment 8403842 [details] [review]
github PR

Thanks for the unit test clean up!
Attachment #8403842 - Flags: review?(schung) → review+
Blocks: 962591
Attachment #8403842 - Flags: review?(anthony) → review+
Thanks for the review!

master: 905d3b518d173e90cb609207a55eb64a188863ce
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.