993955 - Test failure 'Identity is verified' in /testSecurity/testSecurityNotification.js

Status: RESOLVED WORKSFORME

(Mozilla QA Graveyard :: Mozmill Tests, defect, P2)

Description

[Andrei Eftimie]

Module:    /testSecurity/testSecurityNotification.js
Test:      testSecNotification    
Failure:   Identity is verified
Branches:  mozilla-aurora
Platforms: All
Report:    http://mozmill-daily.blargon7.com/#/remote/report/7ab760e27012969ae02e3b9e4140422a

Failed a total of 5 times since March 19th. Win and Linux:
http://mozmill-daily.blargon7.com/#/remote/failure?app=All&branch=All&platform=All&from=2014-03-19&test=%2FtestSecurity%2FtestSecurityNotification.js&func=testSecNotification

Comment 1

[Andreea Matei [:AndreeaMatei]]

From the report, I see this failed a few days ago too, several times and in July a lot. We should investigate this.

Comment 2

[Andrei Eftimie]

I highly suspect _most_ reported failures here are network related. They are time-wise clustered.

Comment 3

[Teodor Druta]

Attachment: b993955.patch

The issue is that the test is not waiting for the identity box element to be visible.
The attached patch should fix the issue.

Comment 4

[Andrei Eftimie]

Comment on attachment 8507714 [details] [diff] [review]
b993955.patch

Review of attachment 8507714 [details] [diff] [review]:
-----------------------------------------------------------------

::: firefox/tests/remote/testSecurity/testSecurityNotification.js
@@ +30,5 @@
>  function testSecNotification() {
>    // Go to a secure HTTPS site
>    controller.open(TEST_DATA[1]);
> +  // wait for page load on the active tab
> +  controller.waitForPageLoad(controller.tabs.activeTab);

By default we are waiting for the most recent opened page, this should not have any effect here.

@@ +39,5 @@
> +  identityBox.waitForElement();
> +
> +  // wait for the identity box to be visible
> +  assert.waitFor(() => utils.isDisplayed(controller, identityBox),
> +                 "Identity Box is Visible !");

We're already waiting below. I don't see how throwing more wait statements will fix the underlying issue.
If the timeout is to short, we can increase it for the below waitFor call.

Comment 5

[Andrei Eftimie]

We actually haven't seen this fail in 1.5 months.

http://mozmill-daily.blargon7.com/#/remote/failure?app=Firefox&branch=All&platform=All&from=2014-09-01&test=%2FtestSecurity%2FtestSecurityNotification.js&func=testSecNotification

It failed on 2 dates:
- on 2014-09-09 (we had a big network outage)
- on 2014-09-11 (not sure, possible other network issue).

We haven't seen this fail since. Closing as WFM.