994050 - [e10s] gfx.direct3d.last_used_feature_level_idx pref should only be set on main process.

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Bob Owen (:bobowen)]

gfx.direct3d.last_used_feature_level_idx is set to save time at start up.

This fails on the content processes, but it only really needs to be set on the main process anyway.

Comment 1

[Bob Owen (:bobowen)]

Attachment: Bug 994050: Only set gfx.direct3d.last_used_feature_level_idx pref from main process.

Just a check for the main process around the pref set and an updated comment.

Try push:
https://tbpl.mozilla.org/?tree=Try&rev=cc8e8574c28e

Comment 2

[Bob Owen (:bobowen)]

Comment on attachment 8403996 [details] [diff] [review]
Bug 994050: Only set gfx.direct3d.last_used_feature_level_idx pref from main process.

Matt - I hope you're OK for a review on this one.
We're a bit out of sync time zone wise to ask on IRC. :-)

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8403996 [details] [diff] [review]
Bug 994050: Only set gfx.direct3d.last_used_feature_level_idx pref from main process.

Review of attachment 8403996 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxWindowsPlatform.cpp
@@ +475,5 @@
>    // the 10.1 check.
>    if (device) {
>      mD2DDevice = cairo_d2d_create_device_from_d3d10device(device);
>  
> +    // Setup a pref for future launch optimizaitons when main process.

when in main process?

Comment 4

[Bob Owen (:bobowen)]

Attachment: Bug 994050: Only set gfx.direct3d.last_used_feature_level_idx pref from main process.

Comment 5

[Bob Owen (:bobowen)]

Comment on attachment 8404548 [details] [diff] [review]
Bug 994050: Only set gfx.direct3d.last_used_feature_level_idx pref from main process.

r=mattwoodrow - from comment 3.

Comment fixed.

try push URL from earlier for ease of access:
https://tbpl.mozilla.org/?tree=Try&rev=cc8e8574c28e

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/285a0529b82d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/285a0529b82d