994079 - Add integration test for calling mozApps.getSelf() twice in close succession

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

This was noticed in bug 987458. The most likely cause is https://hg.mozilla.org/mozilla-central/rev/e59ea92c55fc, so I am making this block bug 915598.

My guess is we will have to keep a count in the platform of how many listeners we have registered for "Webapps:xxx", and only remove the message listener here [1] when that count reaches 0.

1.) https://hg.mozilla.org/mozilla-central/file/7160658c4be3/dom/apps/src/Webapps.js#l56

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Fernando, you worked on bug 915598. Do you agree with the approach mentioned in comment 0? Does the bug report make sense?

Comment 2

[Jason Smith [:jsmith]]

Note - we're probably going to want to get a test for this.

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: Github PR for Gaia Integration Test

Here's an integration test in Gaia that demonstrates the problem.

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Sorry for the silent ni? on me. I couldn't reply at that moment and I set the flag on me so I don't remember to reply.

So I think the approach in comment 0 is correct, but I'd do that in the DOMRequestIPCHelper [1] instead of the WebApps implementation.

[1] https://mxr.mozilla.org/mozilla-central/source/dom/base/DOMRequestHelper.jsm#105

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Well now that this was fixed in bug 1026737, we should probably go ahead and add the integration test I made for this. Re-opening this bug for that purpose. I'll create a new PR, so that we can run it on gaia-try as well as travis.

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: Github PR, integration test for mozApps.getSelf

Fernando, you are familiar with this situation and are a good reviewer :) Would you mind taking a look at this integration test for mozApps.getSelf()? FWIW this used to fail before bug 1010690, but now it passes locally for me.

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

**Meant to say, this used to fail before bug bug 1026737.

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/4233e61019794e3bcd35c3aa5b80c6211e1be652