994135 - Factor generation and compilation of R.java out of Makefile.in

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

Currently, we have two code paths handling generating and compiling R.java files.

1) mobile/android/base/Makefile.in handles everything specially;
2) consumers of ANDROID_APK_NAME do "the wrong thing": R.java is generated in a reasonable fashion, but it's only compiled into classes.dex.  That means files compiled into a JAR can't reference R.java (easily).

This is a chance to correct the ANDROID_APK_NAME logic, and possibly to unify mobile/android/base with the rest of the world.

I can think of two ways this might go.  We might define enough things to write R.java into a sensible place, and then let consuming code reference $(CURDIR)/.../R.java directly.  Or we might define ANDROID_RESOURCE_JAR* things, and build $(CURDIR)/.../R.jar ourselves.  I have a slight preference for the latter, because I think that will make more sense for mobile/android/base.

Comment 1

[Nick Alexander :nalexander [he/him]]

(In reply to Nick Alexander :nalexander from comment #0)

> 2) consumers of ANDROID_APK_NAME do "the wrong thing": R.java is generated
> in a reasonable fashion, but it's only compiled into classes.dex.  That
> means files compiled into a JAR can't reference R.java (easily).

The motivating example is Browser Instrumentation tests in mobile/android/tests/browser/junit3: these tests cannot currently reference org.mozilla.gecko.browser.tests.R.

Comment 2

[Nick Alexander :nalexander [he/him]]

We moved to Gradle long ago.