Closed Bug 994188 Opened 6 years ago Closed 6 years ago

Fix "ReferenceError: Cu is not defined" in browser/components/places/content/controller.js

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 31

People

(Reporter: tetsuharu, Assigned: tetsuharu)

References

Details

Attachments

(1 file)

# env
https://hg.mozilla.org/mozilla-central/rev/5811efc11011

# Abstract
When we enabled Places async transaction, "undo" operation in bookmark sidebar causes "ReferenceError: Cu is not defined".

This is follow-up bug 983623.
Attached patch patchSplinter Review
Attachment #8404073 - Flags: review?(mak77)
Comment on attachment 8404073 [details] [diff] [review]
patch

Review of attachment 8404073 [details] [diff] [review]:
-----------------------------------------------------------------

Why not just do |const Cu = Components.utils;| at the top?
> Why not just do |const Cu = Components.utils;| at the top?

|Ci|, |Cc| are defined in the global scope which loads controller.js.
But I cannot pinpoint their defined points.

controller.js is not JSM. Its loaded order would be sensitive.
Thus I don't define |const Cu| to avoid the redeclaration error.

I agree this patch is very negative-conservative approach.
> I agree this patch is very negative-conservative approach.

I agree someone points "this patch is very negative approach".
Comment on attachment 8404073 [details] [diff] [review]
patch

Review of attachment 8404073 [details] [diff] [review]:
-----------------------------------------------------------------

I agree, we should not pollute this with Cu for now, until we fix bug 406371 properly...
Attachment #8404073 - Flags: review?(mak77) → review+
https://hg.mozilla.org/integration/fx-team/rev/ba4ee20d53cb
Assignee: nobody → saneyuki.s.snyk
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/ba4ee20d53cb
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
QA Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.