994188 - Fix "ReferenceError: Cu is not defined" in browser/components/places/content/controller.js

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

# env
https://hg.mozilla.org/mozilla-central/rev/5811efc11011

# Abstract
When we enabled Places async transaction, "undo" operation in bookmark sidebar causes "ReferenceError: Cu is not defined".

This is follow-up bug 983623.

Comment 1

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: patch

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8404073 [details] [diff] [review]
patch

Review of attachment 8404073 [details] [diff] [review]:
-----------------------------------------------------------------

Why not just do |const Cu = Components.utils;| at the top?

Comment 3

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

> Why not just do |const Cu = Components.utils;| at the top?

|Ci|, |Cc| are defined in the global scope which loads controller.js.
But I cannot pinpoint their defined points.

controller.js is not JSM. Its loaded order would be sensitive.
Thus I don't define |const Cu| to avoid the redeclaration error.

I agree this patch is very negative-conservative approach.

Comment 4

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

> I agree this patch is very negative-conservative approach.

I agree someone points "this patch is very negative approach".

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 8404073 [details] [diff] [review]
patch

Review of attachment 8404073 [details] [diff] [review]:
-----------------------------------------------------------------

I agree, we should not pollute this with Cu for now, until we fix bug 406371 properly...

Comment 6

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

https://hg.mozilla.org/integration/fx-team/rev/ba4ee20d53cb

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ba4ee20d53cb