Closed
Bug 994262
Opened 10 years ago
Closed 10 years ago
ModalDialog confirm() method does not display title
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.4 S5 (11apr)
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
The prototype explicitely declares a 'title' |confirm: function md_confirm(title, text, confirm, cancel)| [https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/modal_dialog.js#L386] and the comment is explicitely stating we can define a title [https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/modal_dialog.js#L380]. However, later in the code, handling the confirm case, an empty title is explicitely set: |this.setTitle('confirm', '');| [https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/modal_dialog.js#L380/].
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Travis is green: https://travis-ci.org/mozilla-b2g/gaia/builds/22668050
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8404452 [details] [review] Link to Github https://github.com/mozilla-b2g/gaia/pull/18143 Alive, since git shows you did most of the work on this component, I'm asking review to you :)
Attachment #8404452 -
Flags: review?(alive)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8404452 [details] [review] Link to Github https://github.com/mozilla-b2g/gaia/pull/18143 Thanks!
Attachment #8404452 -
Flags: review?(alive) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/d81043d2303922e829486c253fe076300d37e9e8
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Whiteboard: [systemsfe]
Target Milestone: --- → 1.4 S5 (11apr)
You need to log in
before you can comment on or make changes to this bug.
Description
•