Closed
Bug 994418
Opened 10 years ago
Closed 9 years ago
width of inside bullet is incorrect when parent is inline-block
Categories
(Core :: Layout: Block and Inline, defect)
Core
Layout: Block and Inline
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
Details
Attachments
(2 files)
143 bytes,
text/html
|
Details | |
3.56 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
When a list has 'list-style-position: inside' with 'display: inline-block', the width of bullet is incorrect. To be more exact, the desired width of bullet is always computed as if the ordinal is zero.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee: nobody → quanxunzhen
Attachment #8595727 -
Flags: review?(roc)
Comment on attachment 8595727 [details] [diff] [review] patch Review of attachment 8595727 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/generic/nsBlockFrame.cpp @@ +693,5 @@ > curFrame->LazyMarkLinesDirty(); > } > > + if (RenumberLists(PresContext())) { > + AddStateBits(NS_FRAME_HAS_DIRTY_CHILDREN); Don't you need to use FrameNeedsReflow here?
Attachment #8595727 -
Flags: review?(roc) → review-
Assignee | ||
Comment 3•9 years ago
|
||
No, and we can't do that, because Get{Min,Pref}ISize are usually called during reflow, but FrameNeedsReflow cannot be called that time.
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8595727 [details] [diff] [review] patch See explanation in comment 3.
Attachment #8595727 -
Flags: review- → review?(roc)
Attachment #8595727 -
Flags: review?(roc) → review+
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a632c89fb1c45f5953227797b531e4a3885a111 Bug 994418 - Renumber list items when computing intrinsic isize. r=roc
Comment 6•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5a632c89fb1c
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•