width of inside bullet is incorrect when parent is inline-block

RESOLVED FIXED in Firefox 45

Status

()

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: xidorn, Assigned: xidorn)

Tracking

Trunk
mozilla45
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

5 years ago
Posted file test case
When a list has 'list-style-position: inside' with 'display: inline-block', the width of bullet is incorrect. To be more exact, the desired width of bullet is always computed as if the ordinal is zero.
Assignee

Comment 1

4 years ago
Posted patch patchSplinter Review
Assignee: nobody → quanxunzhen
Attachment #8595727 - Flags: review?(roc)
Comment on attachment 8595727 [details] [diff] [review]
patch

Review of attachment 8595727 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsBlockFrame.cpp
@@ +693,5 @@
>      curFrame->LazyMarkLinesDirty();
>    }
>  
> +  if (RenumberLists(PresContext())) {
> +    AddStateBits(NS_FRAME_HAS_DIRTY_CHILDREN);

Don't you need to use FrameNeedsReflow here?
Attachment #8595727 - Flags: review?(roc) → review-
Assignee

Comment 3

4 years ago
No, and we can't do that, because Get{Min,Pref}ISize are usually called during reflow, but FrameNeedsReflow cannot be called that time.
Assignee

Comment 4

4 years ago
Comment on attachment 8595727 [details] [diff] [review]
patch

See explanation in comment 3.
Attachment #8595727 - Flags: review- → review?(roc)

Comment 6

4 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5a632c89fb1c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.