994418 - width of inside bullet is incorrect when parent is inline-block

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

Attachment: test case

When a list has 'list-style-position: inside' with 'display: inline-block', the width of bullet is incorrect. To be more exact, the desired width of bullet is always computed as if the ordinal is zero.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8595727 [details] [diff] [review]
patch

Review of attachment 8595727 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsBlockFrame.cpp
@@ +693,5 @@
>      curFrame->LazyMarkLinesDirty();
>    }
>  
> +  if (RenumberLists(PresContext())) {
> +    AddStateBits(NS_FRAME_HAS_DIRTY_CHILDREN);

Don't you need to use FrameNeedsReflow here?

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

No, and we can't do that, because Get{Min,Pref}ISize are usually called during reflow, but FrameNeedsReflow cannot be called that time.

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8595727 [details] [diff] [review]
patch

See explanation in comment 3.

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5a632c89fb1c45f5953227797b531e4a3885a111
Bug 994418 - Renumber list items when computing intrinsic isize. r=roc

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5a632c89fb1c