994419 - Requesting data of non-existent release yields a 500 error

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

eg https://aus4-admin.mozilla.org/releases/Firefox-29.0b9999-build1/data

Comment 1

[[e-mail] (:bhearsum)]

More information, via Sentry (https://errormill.mozilla.org/Releng/balrog-admin-prod/group/166621/):


KeyError: u"Couldn't find release with name 'Firefox-29.0b99-build1'"

Stacktrace (most recent call last):

  File "flask/app.py", line 1292, in wsgi_app
    response = self.full_dispatch_request()
  File "flask/app.py", line 1062, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "flask/app.py", line 1060, in full_dispatch_request
    rv = self.dispatch_request()
  File "flask/app.py", line 1047, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "flask/views.py", line 56, in view
    return self.dispatch_request(*args, **kwargs)
  File "flask/views.py", line 112, in dispatch_request
    return meth(*args, **kwargs)
  File "auslib/admin/views/releases.py", line 199, in get
    release_blob = db.releases.getReleaseBlob(name=release)
  File "auslib/db.py", line 854, in getReleaseBlob
    raise KeyError("Couldn't find release with name '%s'" % name)

Comment 2

[[e-mail] (:bhearsum)]

Attachment: don't 500

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 8409802 [details] [diff] [review]
don't 500

lgtm

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/1befbec2658abf631f1d704697811f9898c22a1e
bug 994419: Requesting data of non-existent release yields a 500 error. r=rail

Comment 5

[[e-mail] (:bhearsum)]

In production, and seems to be working:
➜  tools  curl -I -k [e-mail] https://aus4-admin.mozilla.org/releases/Firefox-29.0b9999-build1/data
Enter host password for user '[e-mail]':
HTTP/1.1 404 NOT FOUND
Server: Apache
X-Backend-Server: ausadm.private.phx1.mozilla.com
Content-Type: text/html; charset=utf-8
Date: Thu, 29 May 2014 18:28:27 GMT
Transfer-Encoding: chunked
X-Content-Type-Options: nosniff
Connection: Keep-Alive
X-Frame-Options: DENY