Closed Bug 994426 Opened 7 years ago Closed 7 years ago

[camera][madai] Options menu items in wrong order

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

x86
macOS
defect
Not set
normal

Tracking

(b2g-v1.4 fixed, b2g-v2.0 fixed)

RESOLVED FIXED
1.4 S6 (25apr)
Tracking Status
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: tif, Assigned: justindarc)

References

Details

Attachments

(1 file)

STR:

Launch camera
Open the options/setting menu

Expected
Options are listed - HDR, Self-Timer, Grid Lines. Grid Lines should always be listed last.


Actual 
Options are listed - HDR, Grid Lines, Self-Timer

Note that for the advanced camera Scene Mode is first and Camera/Video Resolution come before Grid Lines.
Summary: [camera][madai] Options menuitems in wrong order → [camera][madai] Options menu items in wrong order
Minor changes, Youngjun, please take care of this
Flags: needinfo?(jjoons79)
Assignee: nobody → jdarcangelo
Attached file pull-request (master)
tif: i wasn't sure if amylee also needed to ui-review this, if so, please add her
Attachment #8405573 - Flags: ui-review?(tshakespeare)
Attachment #8405573 - Flags: review?(dflanagan)
Comment on attachment 8405573 [details] [review]
pull-request (master)

Trivial change. r+ just by inspection of the code. The only thing that could go wrong here is a typo in a string or a misplaced comma, but assuming that you have run it and have a proper looking menu, it is obvious that the patch is correct.
Attachment #8405573 - Flags: review?(dflanagan) → review+
Comment on attachment 8405573 [details] [review]
pull-request (master)

I'm setting approval to uplift this to 1.4.

Not a blocker, but a totally safe patch that would be silly not to uplift.
Attachment #8405573 - Flags: approval-gaia-v1.4+
Comment on attachment 8405573 [details] [review]
pull-request (master)

Can't comment on the advanced camera menu ordering, but the basic one is correct! Ship It!
Attachment #8405573 - Flags: ui-review?(tshakespeare) → ui-review+
Landed on master:

https://github.com/mozilla-b2g/gaia/commit/468645d2aa565e57fe7ff7db6d3559cce0569c17
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Flags: needinfo?(jjoons79)
You need to log in before you can comment on or make changes to this bug.