994426 - [camera][madai] Options menu items in wrong order

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Tiffanie Shakespeare [:tif]]

STR:

Launch camera
Open the options/setting menu

Expected
Options are listed - HDR, Self-Timer, Grid Lines. Grid Lines should always be listed last.


Actual 
Options are listed - HDR, Grid Lines, Self-Timer

Note that for the advanced camera Scene Mode is first and Camera/Video Resolution come before Grid Lines.

Comment 1

[Hema Koka [:hema]]

Minor changes, Youngjun, please take care of this

Comment 2

[Justin D'Arcangelo [:justindarc]]

Attachment: pull-request (master)

tif: i wasn't sure if amylee also needed to ui-review this, if so, please add her

Comment 3

[David Flanagan [:djf]]

Comment on attachment 8405573 [details] [review]
pull-request (master)

Trivial change. r+ just by inspection of the code. The only thing that could go wrong here is a typo in a string or a misplaced comma, but assuming that you have run it and have a proper looking menu, it is obvious that the patch is correct.

Comment 4

[David Flanagan [:djf]]

Comment on attachment 8405573 [details] [review]
pull-request (master)

I'm setting approval to uplift this to 1.4.

Not a blocker, but a totally safe patch that would be silly not to uplift.

Comment 5

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8405573 [details] [review]
pull-request (master)

Can't comment on the advanced camera menu ordering, but the basic one is correct! Ship It!

Comment 6

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/468645d2aa565e57fe7ff7db6d3559cce0569c17

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/a70595ef862b8142eace5bf589fdfb7647becd58