Closed
Bug 994443
Opened 11 years ago
Closed 11 years ago
Fix slowparse interpretation of @-webkit-keyframes
Categories
(Webmaker Graveyard :: Thimble, defect)
Webmaker Graveyard
Thimble
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bobby, Assigned: michiel)
Details
Attachments
(1 file)
Using "@-webkit-keyframes" or something similar prevents Thimble from rendering the preview. Error in the console: "Uncaught Error: Error template not found for UNKOWN_CSS_KEYWORD errors.jquery.js:91"
slowparse uses the following code:
if(name.match(/@[^k]*keyframes/)) {
...
so it should accept @-webkit-keyframes, I'll add a test case for that to see if it fails on it.
But, the real question is why on earth are you vendor-prefixing? Just use @keyframes, its supported by browsers.
morphing; the regex use is kind of broken because it relies on the letter 'k', which happens to exist in "webkit". The regex should be /@(-[^-]+-)?keyframes/ instead.
Status: NEW → ASSIGNED
Summary: Can't use `@-webkit` or `@-moz` prefixed CSS entries → Fix slowparse interpretation of @-webkit-keyframes
Attachment #8404833 -
Flags: review?(ali)
|
||
Updated•11 years ago
|
Attachment #8404833 -
Flags: review?(ali) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•